You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Jason Letourneau <le...@apache.org> on 2013/01/07 16:04:57 UTC
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 7, 2013, 3:04 p.m.)
Review request for rave.
Summary (updated)
-----------------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs
-----
/trunk/rave-components/rave-core/pom.xml 1429806
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/ActivityStreamObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/repository/ActivityRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1429806
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1429806
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1429806
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Matt Franklin <mf...@apache.org>.
> On Jan. 22, 2013, 5:30 p.m., Matt Franklin wrote:
> > Thanks for the patch and continuing to tweak it for us. A couple of comments and a question:
> >
> > 1) IMO, the convention of keeping model interfaces in org.apache.rave.portal.model should be kept for the activity model interfaces
> > 2) Same as above for the repository in the repository package
> > 3) The impls should keep the existing convention of ending in Impl instead of Entity
> > 4) There is a lot of serialization/deserialization machinery, but I didn't see an endpoint as part of the patch. Where is this used?
Nevermind on 1 & 2. I must have grabbed an old version of the patch. The only outstanding comments are 3 & 4.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15572
-----------------------------------------------------------
On Jan. 22, 2013, 3:51 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 3:51 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15572
-----------------------------------------------------------
Thanks for the patch and continuing to tweak it for us. A couple of comments and a question:
1) IMO, the convention of keeping model interfaces in org.apache.rave.portal.model should be kept for the activity model interfaces
2) Same as above for the repository in the repository package
3) The impls should keep the existing convention of ending in Impl instead of Entity
4) There is a lot of serialization/deserialization machinery, but I didn't see an endpoint as part of the patch. Where is this used?
- Matt Franklin
On Jan. 22, 2013, 3:51 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 3:51 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
> On Jan. 22, 2013, 9:10 p.m., Matt Franklin wrote:
> > /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java, line 55
> > <https://reviews.apache.org/r/8861/diff/4/?file=251073#file251073line55>
> >
> > This is a gson annotation. Since we aren't using GSON anywhere else, I am not sure it makes sense in this context to add these annotations
I've gained a new understanding of what is useful in this patch vs what I thought was useful. I'll be re-submitting with most of the focus on the ActivitiesService implementation and the GSON/Serialization to and from JSON streams removed.
- Jason
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15583
-----------------------------------------------------------
On Jan. 22, 2013, 8:39 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 8:39 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15583
-----------------------------------------------------------
Sorry, I just saw a few more things.
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java
<https://reviews.apache.org/r/8861/#comment33667>
Rave already contains a JpaUtil with a getSingleResult method.
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java
<https://reviews.apache.org/r/8861/#comment33668>
I am a little confused on how it gets in the way... can you elaborate?
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java
<https://reviews.apache.org/r/8861/#comment33664>
This is a gson annotation. Since we aren't using GSON anywhere else, I am not sure it makes sense in this context to add these annotations
- Matt Franklin
On Jan. 22, 2013, 8:39 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2013, 8:39 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializerTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15806
-----------------------------------------------------------
Ship it!
There are still a few minor issues, but I can take care of them after applying the patch.
/trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java
<https://reviews.apache.org/r/8861/#comment34021>
Minor - This was intentionally marked private to force static method use.
/trunk/rave-components/rave-core/pom.xml
<https://reviews.apache.org/r/8861/#comment34022>
No longer used. Can be removed
/trunk/rave-components/rave-core/pom.xml
<https://reviews.apache.org/r/8861/#comment34024>
New dependency should be managed from master pom
/trunk/rave-components/rave-core/pom.xml
<https://reviews.apache.org/r/8861/#comment34023>
No longer used. Can be removed.
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java
<https://reviews.apache.org/r/8861/#comment34025>
Interface should not declare method modifier.
Does not need to return generic
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml
<https://reviews.apache.org/r/8861/#comment34026>
there appears to be nothing in this package worth scanning. can be removed
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java
<https://reviews.apache.org/r/8861/#comment34027>
Mappings will need to be to other Jpa Entities
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml
<https://reviews.apache.org/r/8861/#comment34028>
This no longer needs to be here
- Matt Franklin
On Jan. 28, 2013, 9:04 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 9:04 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java 1437003
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsEntry.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsItem.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsMediaLink.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsEntryImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsMediaLinkImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsObjectImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsMediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsMediaLink.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsObject.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsEntryConverter.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsMediaLinkConverter.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsObjectConverter.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsMediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsEntryConverterTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsMediaLinkConverterTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsObjectConverterTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java 1437003
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/util/ActivityConversionUtil.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/util/ActivityConversionUtilTest.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/resources/rave-shindig-test-applicationContext.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 28, 2013, 9:04 p.m.)
Review request for rave.
Changes
-------
I believe this resolves Matt's latest comments.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs (updated)
-----
/trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java 1437003
/trunk/rave-components/rave-core/pom.xml 1437003
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsEntry.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsItem.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsMediaLink.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsEntryImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsMediaLinkImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsObjectImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsEntryTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsMediaLinkTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsObjectTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsMediaLink.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsObject.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsEntryConverter.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsMediaLinkConverter.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsObjectConverter.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsEntryTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsMediaLinkTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsObjectTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsEntryConverterTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsMediaLinkConverterTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaActivityStreamsObjectConverterTest.java PRE-CREATION
/trunk/rave-components/rave-mongodb/pom.xml 1437003
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java 1437003
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/util/ActivityConversionUtil.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/util/ActivityConversionUtilTest.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/resources/rave-shindig-test-applicationContext.xml 1437003
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Matt Franklin <mf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15751
-----------------------------------------------------------
Thanks for working through these issues and your patience
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java
<https://reviews.apache.org/r/8861/#comment33906>
This interface should just return or accept the ActivityStreamsXxx Interface
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java
<https://reviews.apache.org/r/8861/#comment33907>
What happens if this is an instance of ActivityStreamsEntryImpl and not JpaActivityStreamsEntry?
- Matt Franklin
On Jan. 25, 2013, 8:31 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2013, 8:31 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java 1437003
> /trunk/rave-components/rave-core/pom.xml 1437003
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsEntryImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsMediaLinkImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsObjectImpl.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsMediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsMediaLink.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsObject.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsEntryTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsMediaLinkTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsObjectTest.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
> /trunk/rave-components/rave-mongodb/pom.xml 1437003
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java 1437003
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/util/ActivityConversionUtil.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/util/ActivityConversionUtilTest.java PRE-CREATION
> /trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/resources/rave-shindig-test-applicationContext.xml 1437003
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 25, 2013, 8:31 p.m.)
Review request for rave.
Changes
-------
this patch includes the core activity streams models, tests, and activity streams service.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs (updated)
-----
/trunk/rave-components/rave-commons/src/main/java/org/apache/rave/persistence/jpa/util/JpaUtil.java 1437003
/trunk/rave-components/rave-core/pom.xml 1437003
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamsObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsEntryImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsMediaLinkImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityStreamsObjectImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityStreamsRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsEntryTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsMediaLinkTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityStreamsObjectTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsEntry.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsMediaLink.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityStreamsObject.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityStreamsRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsEntryTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsMediaLinkTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityStreamsObjectTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
/trunk/rave-components/rave-mongodb/pom.xml 1437003
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java 1437003
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/util/ActivityConversionUtil.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/util/ActivityConversionUtilTest.java PRE-CREATION
/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/resources/rave-shindig-test-applicationContext.xml 1437003
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 8:39 p.m.)
Review request for rave.
Changes
-------
I've addressed #3 from Matt in this patch. I will submit a separate patch for #4 for the ActivitiesStreamsService in another patch.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs (updated)
-----
/trunk/rave-components/rave-core/pom.xml 1437003
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkImpl.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryDeserializerTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectDeserializerTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
/trunk/rave-components/rave-mongodb/pom.xml 1437003
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 3:51 p.m.)
Review request for rave.
Changes
-------
updated diff against HEAD after update locally
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs (updated)
-----
/trunk/rave-components/rave-core/pom.xml 1437003
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/ActivityStreamObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/MediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/repository/ActivityRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1437003
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntityTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntityTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntityTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializerTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializerTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/serialization/ActivityStreamParserTest.java PRE-CREATION
/trunk/rave-components/rave-core/src/test/java/org/apache/rave/portal/activities/util/ModelUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaMediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaActivityEntryRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1437003
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1437003
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntityTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepositoryTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/repository/util/JpaUtilTest.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParserTest.java PRE-CREATION
/trunk/rave-components/rave-mongodb/pom.xml 1437003
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 3:44 p.m.)
Review request for rave.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs
-----
/trunk/rave-components/rave-core/pom.xml 1435287
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1435287
/trunk/rave-components/rave-mongodb/pom.xml 1435287
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 22, 2013, 3:43 p.m.)
Review request for rave.
Changes
-------
i forgot the -r option on the diff generation...
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs
-----
/trunk/rave-components/rave-core/pom.xml 1435287
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1435287
/trunk/rave-components/rave-mongodb/pom.xml 1435287
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15494
-----------------------------------------------------------
Jason, Can you please upload the consolidated patch to RAVE-865 for me to test? visually everything looks good with the different version patches.
- Raminder Singh
On Jan. 18, 2013, 6:54 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 6:54 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1435287
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1435287
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1435287
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1435287
> /trunk/rave-components/rave-mongodb/pom.xml 1435287
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 6:54 p.m.)
Review request for rave.
Changes
-------
We've updated the patch based on the requests by Raminder - including the removal on the personal tags and addition of the unit tests. I've also refactored the java class organization a bit to more closely align with the existing rave structure. There still exists a package for activities for things that are very activities specific (i.e. serialization classes and specification related classes).
Jason
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs (updated)
-----
/trunk/rave-components/rave-core/pom.xml 1435287
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1435287
/trunk/rave-components/rave-mongodb/pom.xml 1435287
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Raminder Singh <ra...@apache.org>.
> On Jan. 7, 2013, 8:16 p.m., Raminder Singh wrote:
> >
I found some minor issue like missing apache license, personal signatures (remove Idea @author tag etc). Code looks good to me but i am not able to test is using ActivityStreams gadget because org.apache.rave.opensocial.service.impl.MultiFormatActivityService need to be implemented. There is an other issue with BLOB not supported by H2. You will see lot of Warn messages on console while starting cargo. Jason can you also provide instructions to test this and add unit test for the code.
- Raminder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15120
-----------------------------------------------------------
On Jan. 7, 2013, 3:05 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 3:05 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1429806
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1429806
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1429806
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1429806
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/#review15120
-----------------------------------------------------------
/trunk/rave-components/rave-core/pom.xml
<https://reviews.apache.org/r/8861/#comment32710>
I have some dependency conflict because of this jar to build rave-mongodb.
- Raminder Singh
On Jan. 7, 2013, 3:05 p.m., Jason Letourneau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8861/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2013, 3:05 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
>
>
> Diffs
> -----
>
> /trunk/rave-components/rave-core/pom.xml 1429806
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/ActivityStreamObject.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/repository/ActivityRepository.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/util/ModelUtil.java PRE-CREATION
> /trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1429806
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntity.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepository.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
> /trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1429806
> /trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1429806
>
> Diff: https://reviews.apache.org/r/8861/diff/
>
>
> Testing
> -------
>
> built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
>
>
> Thanks,
>
> Jason Letourneau
>
>
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 6:54 p.m.)
Review request for rave.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs
-----
/trunk/rave-components/rave-core/pom.xml 1435287
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1435287
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1435287
/trunk/rave-components/rave-mongodb/pom.xml 1435287
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau
Re: Review Request: RAVE-865 - Add Activity Streams (activitystrea.ms)
classes (model, repository, core, and JPA) to Rave components
Posted by Jason Letourneau <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8861/
-----------------------------------------------------------
(Updated Jan. 7, 2013, 3:05 p.m.)
Review request for rave.
Description
-------
RAVE-865 - Add Activity Streams (activitystrea.ms) classes (model, repository, core, and JPA) to Rave components
Diffs
-----
/trunk/rave-components/rave-core/pom.xml 1429806
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/ActivityStreamObject.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/ActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/model/impl/MediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/repository/ActivityRepository.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityEntryEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityObjectEntityDeserializer.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/serialization/ActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityEntryComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectName.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectType.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/ActivityObjectVerb.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/MediaLinkComponent.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/specification/OpenSocialActivityExtensions.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/activities/util/ModelUtil.java PRE-CREATION
/trunk/rave-components/rave-core/src/main/resources/org/apache/rave/core-applicationContext.xml 1429806
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityEntryEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaActivityObjectEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/model/impl/JpaMediaLinkEntity.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/JpaActivityEntryRepository.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/repository/util/JpaUtil.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/activities/serialization/JpaActivityStreamParser.java PRE-CREATION
/trunk/rave-components/rave-jpa/src/main/resources/META-INF/persistence.xml 1429806
/trunk/rave-components/rave-jpa/src/main/resources/org/apache/rave/persistence-applicationContext.xml 1429806
Diff: https://reviews.apache.org/r/8861/diff/
Testing
-------
built and deployed on Mac OSX Mountain Lion development environment. Code ported from proof of concept activity stream project using rave-shindig.
Thanks,
Jason Letourneau