You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/27 09:28:52 UTC
[jira] [Commented] (FLINK-4121) Add timeunit (ms) to docs for
timestamps and watermarks
[ https://issues.apache.org/jira/browse/FLINK-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350699#comment-15350699 ]
ASF GitHub Bot commented on FLINK-4121:
---------------------------------------
GitHub user powibol opened a pull request:
https://github.com/apache/flink/pull/2165
[FLINK-4121] Add timeunit (ms) to docs for timestamps and watermarks
This PR inserts an explicit specification of the timeunit used in watermarks and timestamps in the documentation. (According to FLINK-4121).
I'm teaching a class where students are supposed to implement Flink streaming programs. It seems to be unclear for them, that the time unit of timestamps and watermarks is milliseconds. They just see TimeWindow.seconds(...) or something similar and assume the timestamps to be of the same unit (seconds) which is obviously not the case. I just checked the documentation and there is no explicit specification of the time unit used for timestamps. After short talk with Aljoscha Krettek, I'll open a mini-PR to address this issue.
@aljoscha Please let me know in case you need anything else to merge this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/powibol/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2165
----
commit 313a2701b8843f2b284c11274113ed796e04ac3a
Author: Jonas Traub <jo...@s-traub.com>
Date: 2016-06-27T09:06:16Z
[FLINK-4121] Add timeunit (ms) to docs for timestamps and watermarks
----
> Add timeunit (ms) to docs for timestamps and watermarks
> -------------------------------------------------------
>
> Key: FLINK-4121
> URL: https://issues.apache.org/jira/browse/FLINK-4121
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Jonas Traub
> Priority: Trivial
>
> I'm teaching a class where students are supposed to implement Flink streaming programs. It seems to be unclear for them, that the time unit of timestamps and watermarks is milliseconds.
> They just see TimeWindow.seconds(...) or something similar and assume the timestamps to be of the same unit (seconds) which is obviously not the case.
> I just checked the documentation and there is no explicit specification of the time unit used for timestamps.
> After short talk with [~aljoscha], I'll open a mini-PR to address this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)