You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gaborgsomogyi (via GitHub)" <gi...@apache.org> on 2024/08/29 08:22:33 UTC
[PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
gaborgsomogyi opened a new pull request, #25262:
URL: https://github.com/apache/flink/pull/25262
## What is the purpose of the change
Some of the places we still have `checkpointing-with-parts-of-the-graph-finished-beta` link instead of `checkpointing-with-parts-of-the-graph-finished` which doesn't lead anywhere. In this PR I've fixed it.
## Brief change log
Fixed `checkpointing-with-parts-of-the-graph-finished` link in checkpoint documentation.
## Verifying this change
* `docker run -v $(pwd):/src -p 1313:1313 jakejarvis/hugo-extended:latest server --buildDrafts --buildFuture --bind 0.0.0.0`
* Manually visited locally generated page
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25262:
URL: https://github.com/apache/flink/pull/25262#discussion_r1738893785
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -18,7 +18,7 @@
<td><h5>execution.checkpointing.checkpoints-after-tasks-finish</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished-beta">the important considerations</a> </td>
+ <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished">the important considerations</a> </td>
Review Comment:
Shouldn't it also be fixed in Chinese doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317275532
Backport to 1.20 makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317138209
cc @gyfora @ferenc-csaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317195551
I think this is there for quite some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on code in PR #25262:
URL: https://github.com/apache/flink/pull/25262#discussion_r1738934310
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -18,7 +18,7 @@
<td><h5>execution.checkpointing.checkpoints-after-tasks-finish</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished-beta">the important considerations</a> </td>
+ <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished">the important considerations</a> </td>
Review Comment:
I don't see issues in other places, but if you point to exact lines then we can see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi merged PR #25262:
URL: https://github.com/apache/flink/pull/25262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317386747
Some unrelated issues:
```
08:48:23.638 [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.12.1:install-node-and-npm (install node and npm) on project flink-runtime-web: Could not extract the Node archive: Could not extract archive: '/__w/3/.m2/repository/com/github/eirslett/node/16.13.2/node-16.13.2-linux-x64.tar.gz': EOFException -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #25262:
URL: https://github.com/apache/flink/pull/25262#discussion_r1739033510
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -18,7 +18,7 @@
<td><h5>execution.checkpointing.checkpoints-after-tasks-finish</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished-beta">the important considerations</a> </td>
+ <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished">the important considerations</a> </td>
Review Comment:
yep, my bad, i noticed there is an occurrence in `docs/content.zh/release-notes/flink-1.15.md` which is release related and shouldn't be touched.
Sorry for the false positive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317009175
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a95c9fa73e60e0c6e8485c560c264e49c01c2791",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a95c9fa73e60e0c6e8485c560c264e49c01c2791",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a95c9fa73e60e0c6e8485c560c264e49c01c2791 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317197421
Though not really sure how severe it is to add backports. We can do if we think so...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "gaborgsomogyi (via GitHub)" <gi...@apache.org>.
gaborgsomogyi commented on code in PR #25262:
URL: https://github.com/apache/flink/pull/25262#discussion_r1739185166
##########
docs/layouts/shortcodes/generated/checkpointing_configuration.html:
##########
@@ -18,7 +18,7 @@
<td><h5>execution.checkpointing.checkpoints-after-tasks-finish</h5></td>
<td style="word-wrap: break-word;">true</td>
<td>Boolean</td>
- <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished-beta">the important considerations</a> </td>
+ <td>Feature toggle for enabling checkpointing even if some of tasks have finished. Before you enable it, please take a look at <a href="{{.Site.BaseURL}}{{.Site.LanguagePrefix}}/docs/dev/datastream/fault-tolerance/checkpointing/#checkpointing-with-parts-of-the-graph-finished">the important considerations</a> </td>
Review Comment:
Thanks for the review and the conformation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36173][docs] Fix invalid link in checkpoint documentation [flink]
Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #25262:
URL: https://github.com/apache/flink/pull/25262#issuecomment-2317142667
Thanks for the fix! Is this only relevant for 2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org