You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/05 15:56:04 UTC

[GitHub] [airflow] dstandish edited a comment on pull request #20658: Rename `to_delete` to `to_cancel` in TriggerRunner

dstandish edited a comment on pull request #20658:
URL: https://github.com/apache/airflow/pull/20658#issuecomment-1005849380


   > LGTM, Is backward compatibility an issue here?
   
   Just chatted with @ashb and his position is that methods like this on the trigger internals, or scheduler internals, should be considered private and can be refactored freely.   But added that we should probablly also try to indicate that somewhere in the docs -- that there's no guarantee that they won't change from [minor] version to version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org