[GitHub] [arrow] jorgecarleitao commented on pull request #7751: ARROW-9461: [Rust] Fixed error in reading Date32 and Date64.

[GitBox <gi...@apache.org>]

jorgecarleitao commented on pull request #7751:
URL: https://github.com/apache/arrow/pull/7751#issuecomment-658854948


   Thanks @andygrove and @sunchao for taking the time to look at this.
   
   I had to [change an existing test](https://github.com/apache/arrow/pull/7751/files#diff-fca053527b552a9f2abb1e280e570cb6R1165) for this to pass the tests, and thus understood that this was already covered.
   
   My understanding is that the current test is incorrect because it asserts that the logical type string `"DATE"` is represented by the logical type `UInt32` and native type `u32` -- this PR changes this assert so that `"DATE"` is represented by `Date32`, of native type `i32`, to be consistent with the statement
   
   ```
   make_type!(Date32Type, i32, DataType::Date32(DateUnit::Day), 32, 0i32);
   ```
   
   that we use to declare the DateType on our (in-memory representation) side.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org