You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/15 17:28:08 UTC
[GitHub] [cordova-fetch] raphinesse opened a new pull request #88: fix: do not pack rejections from resolve in array
raphinesse opened a new pull request #88:
URL: https://github.com/apache/cordova-fetch/pull/88
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
We use the package `resolve` to find out if a requested dependency is already installed. That package exports a callback based async API that we promisify using `pify`. Since the callback of `resolve` is called with multiple result arguments, we need to use the `multiArgs` option of `pify` here. Unfortunately that also wraps the errors of `resolve` into an array.
### Description
<!-- Describe your changes in detail -->
This PR unwraps the errors returned by our promisified `resolve`.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Manual
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] raphinesse merged pull request #88: fix: do not pack rejections from resolve in array
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #88:
URL: https://github.com/apache/cordova-fetch/pull/88
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io commented on pull request #88: fix: do not pack rejections from resolve in array
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #88:
URL: https://github.com/apache/cordova-fetch/pull/88#issuecomment-709477375
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=h1) Report
> Merging [#88](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/c19f8887210d53c10f12a359742a81b02268ea36?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 92.18% 92.30% +0.12%
==========================================
Files 1 1
Lines 64 65 +1
==========================================
+ Hits 59 60 +1
Misses 5 5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/88/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `92.30% <100.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=footer). Last update [c19f888...a7a1f48](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #88: fix: do not pack rejections from resolve in array
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #88:
URL: https://github.com/apache/cordova-fetch/pull/88#issuecomment-709477375
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=h1) Report
> Merging [#88](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/c19f8887210d53c10f12a359742a81b02268ea36?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 92.18% 92.30% +0.12%
==========================================
Files 1 1
Lines 64 65 +1
==========================================
+ Hits 59 60 +1
Misses 5 5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/88/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `92.30% <100.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=footer). Last update [c19f888...a7a1f48](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #88: fix: do not pack rejections from resolve in array
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #88:
URL: https://github.com/apache/cordova-fetch/pull/88#issuecomment-709477375
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=h1) Report
> Merging [#88](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/c19f8887210d53c10f12a359742a81b02268ea36?el=desc) will **increase** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 92.18% 92.30% +0.12%
==========================================
Files 1 1
Lines 64 65 +1
==========================================
+ Hits 59 60 +1
Misses 5 5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/88/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `92.30% <100.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=footer). Last update [c19f888...57bdd23](https://codecov.io/gh/apache/cordova-fetch/pull/88?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org