You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/04 17:08:58 UTC

Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35075/
-----------------------------------------------------------

Review request for mesos, Alexander Rojas and Till Toenshoff.


Repository: mesos


Description
-------

Addressed issues mentioned for https://reviews.apache.org/r/33331/.


Diffs
-----

  docs/mesos-c++-style-guide.md ddd1cb6faf5b1e82dd3dad69df30aec402935e96 

Diff: https://reviews.apache.org/r/35075/diff/


Testing
-------

Rendered version: https://gist.github.com/joerg84/9b3e985ab847cc9baabe


Thanks,

Joerg Schad


Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

Posted by Till Toenshoff <to...@me.com>.

> On June 4, 2015, 3:10 p.m., Till Toenshoff wrote:
> > Ship It!

Thanks Joerg!


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35075/#review86626
-----------------------------------------------------------


On June 4, 2015, 3:08 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35075/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed issues mentioned for https://reviews.apache.org/r/33331/.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md ddd1cb6faf5b1e82dd3dad69df30aec402935e96 
> 
> Diff: https://reviews.apache.org/r/35075/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/9b3e985ab847cc9baabe
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35075/#review86626
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On June 4, 2015, 3:08 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35075/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Addressed issues mentioned for https://reviews.apache.org/r/33331/.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md ddd1cb6faf5b1e82dd3dad69df30aec402935e96 
> 
> Diff: https://reviews.apache.org/r/35075/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/joerg84/9b3e985ab847cc9baabe
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>