You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 11:10:54 UTC

[GitHub] [flink] wuchong commented on a change in pull request #14330: [FLINK-20500][upsert-kafka] Fix unstable UpsertKafkaTableITCase.testT…

wuchong commented on a change in pull request #14330:
URL: https://github.com/apache/flink/pull/14330#discussion_r538250499



##########
File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java
##########
@@ -385,6 +384,7 @@ private void wordFreqToUpsertKafka(String wordCountTable) throws Exception {
 	}
 
 	private void writeChangelogToUpsertKafkaWithMetadata(String userTable) throws Exception {
+		env.setParallelism(1);

Review comment:
       I would suggest to move the parallelism setting to `testTemporalJoin()` before calling `writeChangelogToUpsertKafkaWithMetadata()` and add a note. Otherwise, other contributors may don't understand this and change it in the future.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org