You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Roshan Naik <ro...@hortonworks.com> on 2014/11/20 03:04:48 UTC
Re: Review Request 16179: Patch for FLUME-2246 - event body data size
can make it configurable for logger sinker
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16179/#review62319
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
<https://reviews.apache.org/r/16179/#comment104346>
Lets fix the asterisks import since that seems to be covention adopted by Flume.
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
<https://reviews.apache.org/r/16179/#comment104345>
Consider renaming to "maxBytesToLog"
flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java
<https://reviews.apache.org/r/16179/#comment104344>
maxBytesToDump is not being reverted to default in the event of exception.
This can happen during reconfigure when going from a previous non-default value to a new badly speciifed value.
- Roshan Naik
On Dec. 11, 2013, 9:58 a.m., Ashish Paliwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16179/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 9:58 a.m.)
>
>
> Review request for Flume.
>
>
> Bugs: FLUME-2246
> https://issues.apache.org/jira/browse/FLUME-2246
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Added configuration options to let user select the max bytes to dump in log file. Default stays at 16 bytes.
>
> Change summary
> Made LoggerSink implement configurable
> user can provide maxByteToDump using configuration
> User Guide updated
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java 128fa84
> flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe
> flume-ng-doc/sphinx/FlumeUserGuide.rst ae66f89
>
> Diff: https://reviews.apache.org/r/16179/diff/
>
>
> Testing
> -------
>
> Added test case that sets option to a value higher than 30 and use a string of length greater than 16 in output.
>
>
> Thanks,
>
> Ashish Paliwal
>
>