You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/08/22 14:41:36 UTC

[GitHub] flink pull request #2401: [FLINK-4443][rpc] Add support in RpcCompletenessTe...

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2401#discussion_r75690051
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rpc/RpcGateway.java ---
    @@ -28,5 +28,6 @@
     	 *
     	 * @return Fully qualified address under which the associated rpc endpoint is reachable
     	 */
    +	@NativeMethod
     	String getAddress();
    --- End diff --
    
    Can't we simply say that all methods defined in `RpcGateway` are implicitly a *native* method. Then we could save the `@NativeMethod` annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---