You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/09 21:14:19 UTC
[GitHub] [airflow] petedejoy opened a new pull request #7670: [AIRFLOW-XXXX]
Small grammar fixes in FAQ doc
petedejoy opened a new pull request #7670: [AIRFLOW-XXXX] Small grammar fixes in FAQ doc
URL: https://github.com/apache/airflow/pull/7670
---
This PR adds some grammatical and structural improvements to the FAQ doc currently available at https://airflow.apache.org/docs/stable/best-practices.html.
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] petedejoy commented on issue #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
petedejoy commented on issue #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670#issuecomment-596786177
My apologies! Jumped the gun on this- was reading through this doc and just clicked the `Suggest a change on this page` link, which pushed me to update the .rst file directly and make a PR in one fell swoop.
I will say, the doc editing flow for someone who isn't deeply familiar with the PR process is a bit odd; I was prompted to make the commit with the default message _before_ being given the PR checklist that tells me what to do with commit messages. Definitely on me for not brushing up on the entire process beforehand, but for a user reading through docs who just wants to help clean them up, it's a bit challenging.
Regardless, I'll roll it back and make sure the proper commit message is used. I also have some other updates to this doc that I plan on making.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670#issuecomment-596783836
You still need to update commit title though :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670#issuecomment-596789465
No worries! Thanks for trying to improve things :). It's just our automation around merging makes some rules necessary!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] petedejoy commented on issue #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
petedejoy commented on issue #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670#issuecomment-596790570
Totally understand. I'll have the reverted commit with some more updates coming up shortly. Thanks, @potiuk!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7670: [AIRFLOW-XXXX] Small
grammar fixes in Best Practices doc
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7670: [AIRFLOW-XXXX] Small grammar fixes in Best Practices doc
URL: https://github.com/apache/airflow/pull/7670#issuecomment-597053992
Thanks @petedejoy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services