Re: [PR] [fix](multi-catalog)access HMS need ugiDoAs [doris]

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #30595:
URL: https://github.com/apache/doris/pull/30595#discussion_r1474203248


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/ThriftHMSCachedClient.java:
##########
@@ -307,7 +309,10 @@ public long openTxn(String user) {
     public void commitTxn(long txnId) {
         try (ThriftHMSClient client = getClient()) {
             try {
-                client.client.commitTxn(txnId);
+                ugiDoAs(() -> {
+                    client.client.commitTxn(txnId);
+                    return null;

Review Comment:
   why return null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org