You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Pavel Tupitsyn (Jira)" <ji...@apache.org> on 2023/04/21 13:38:00 UTC

[jira] [Commented] (IGNITE-19270) Thin 3.0: Streamline type codes

    [ https://issues.apache.org/jira/browse/IGNITE-19270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17715013#comment-17715013 ] 

Pavel Tupitsyn commented on IGNITE-19270:
-----------------------------------------

Merged to main: b395b21855dd924e8bb2601a09c813bdbb5f62c5

> Thin 3.0: Streamline type codes
> -------------------------------
>
>                 Key: IGNITE-19270
>                 URL: https://issues.apache.org/jira/browse/IGNITE-19270
>             Project: Ignite
>          Issue Type: Improvement
>          Components: thin client
>    Affects Versions: 3.0.0-beta1
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Major
>              Labels: ignite-3
>             Fix For: 3.0.0-beta2
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have too many different type codes:
> * org.apache.ignite.sql.ColumnType
> * org.apache.ignite.internal.client.proto.ClientDataType
> * org.apache.ignite.internal.client.proto.ClientColumnTypeConverter (uses it's own codes)
> We can probably replace everything with *org.apache.ignite.sql.ColumnType* and use ordinals from there. .NET and C++ tests will protect us from breaking the protocol accidentally. And we can write an additional test that explains why you can't change ordinals there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)