[GitHub] [arrow] bkietz commented on a change in pull request #10947: ARROW-13638: [C++] Hold owned copy of function options in GroupByNode

[GitBox <gi...@apache.org>]

bkietz commented on a change in pull request #10947:
URL: https://github.com/apache/arrow/pull/10947#discussion_r690526076



##########
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##########
@@ -256,14 +256,16 @@ struct GroupByNode : ExecNode {
               const std::vector<int>&& key_field_ids,
               const std::vector<int>&& agg_src_field_ids,
               const std::vector<internal::Aggregate>&& aggs,
-              const std::vector<const HashAggregateKernel*>&& agg_kernels)
+              const std::vector<const HashAggregateKernel*>&& agg_kernels,

Review comment:
       If you wouldn't mind cleaning this up:
   ```suggestion
                 std::vector<const HashAggregateKernel*> agg_kernels,
   ```
   also ExecNode subclasses shouldn't be `struct`s




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org