[jira] [Commented] (FLUME-2738) Async HBase sink FD leak on client shutdown

["Hari Shreedharan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619275#comment-14619275 ] 

Hari Shreedharan commented on FLUME-2738:
-----------------------------------------

I don't see how this fixes the issue. Tracing the {{releaseExternalResources}} calls only shows a bunch of buffers being cleared up. It is nice to clear up memory, but where are the sockets or FDs being closed/nulled out? I don't see that anywhere in the {{releaseExternalResources}} call chain.

> Async HBase sink FD leak on client shutdown
> -------------------------------------------
>
>                 Key: FLUME-2738
>                 URL: https://issues.apache.org/jira/browse/FLUME-2738
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Johny Rufus
>            Assignee: Johny Rufus
>         Attachments: FLUME-2738.patch
>
>
> Currently every time Async Hbase Sink calls HBaseSink.shutdown, there is FD leak due to HBaseSink using CustomChannelFactory where releaseExternalResources() is overridden to a No-op. Need to replace this with a standard NioClientSocketChannelFactory, that releases external resources properly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)