You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nikolay Khitrin (JIRA)" <ji...@apache.org> on 2014/07/11 15:33:14 UTC

[jira] [Created] (LUCENE-5816) ToParentBlockJoin deothogonalization

Nikolay Khitrin created LUCENE-5816:
---------------------------------------

             Summary: ToParentBlockJoin deothogonalization
                 Key: LUCENE-5816
                 URL: https://issues.apache.org/jira/browse/LUCENE-5816
             Project: Lucene - Core
          Issue Type: Improvement
          Components: modules/join
    Affects Versions: 4.9
            Reporter: Nikolay Khitrin


For now ToParentBlockJoinQuery accepts only child
documents. Before (LUCENE-4968) passing parent document to TPBJQ lead to
undefined behavior and garbage in results, unfortunatelly it also affects
TPBJQ.advance().  After pointed patch IllegalStateException is
thrown when this occurs.

So we must always take parent-child relations into account while writing
queries. At most of time it is necessary when writing a query, but sometimes,
filters can be independent of data model (for example, ACL filters:
+TPBJQ +allowed:user).

TPBJQ shall returns parent doc if parent doc is passed to TPBJQ.advance()
or returned from childScorer.advance(). This change doesn't break anything:
results will be absolutely the same for parent-child orthogonal result.

In few words: Document matching parent filter should be parent of itself.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org