[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #955: MINIFICPP-1414 Create in-memory compressed logs

[GitBox <gi...@apache.org>]

martinzink commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r568589948



##########
File path: conf/minifi-log.properties
##########
@@ -45,3 +45,11 @@ logger.org::apache::nifi::minifi=INFO,rolling
 
 #Logging configurable by class fully qualified name
 #logger.org::apache::nifi::minifi::core::logging::LoggerConfiguration=DEBUG
+
+# Log compression #
+## Enables the agent to keep a limited chunk of the application
+## logs in memory in compressed format. Note that due to its
+## compressed nature this could mean more logs than the contents
+## of the log files.
+#compression.cached.log.max.size=8 MB
+#compression.compressed.log.max.size=8 MB

Review comment:
       It could be mentioned here that setting any of these to zero opts out from this feature (instead of for example making the log size unlimited), maybe even add a unit test to verify this behavior.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org