You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/31 05:19:24 UTC
[GitHub] [accumulo] skirklin opened a new pull request, #2906: convert text to printable string before logging in merge tablets
skirklin opened a new pull request, #2906:
URL: https://github.com/apache/accumulo/pull/2906
I went with `toPrintableString` since that format is pretty readable, but if some other encoding is preferred for some reason, I don't have a preference. Just want to avoid getting vt100 control characters that reconfigure my terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] skirklin commented on a diff in pull request #2906: convert text to printable string before logging in merge tablets
Posted by GitBox <gi...@apache.org>.
skirklin commented on code in PR #2906:
URL: https://github.com/apache/accumulo/pull/2906#discussion_r959548835
##########
core/src/main/java/org/apache/accumulo/core/util/Merge.java:
##########
@@ -225,8 +226,9 @@ protected void merge(AccumuloClient client, String table, List<Size> sizes, int
try {
Text start = sizes.get(0).extent.prevEndRow();
Text end = sizes.get(numToMerge - 1).extent.endRow();
- message("Merging %d tablets from (%s to %s]", numToMerge, start == null ? "-inf" : start,
- end == null ? "+inf" : end);
+ message("Merging %d tablets from (%s to %s]", numToMerge,
+ start == null ? "-inf" : Key.toPrintableString(start.getBytes(), 0, start.getLength(), end.getLength()),
Review Comment:
ah, definitely, thanks! Fix in flight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #2906: convert text to printable string before logging in merge tablets
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #2906:
URL: https://github.com/apache/accumulo/pull/2906#issuecomment-1232906423
PR fails file formatting validation. You can run `mvn clean package -DskipTests` locally which will format the file and run the unit tests, among other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2906: convert text to printable string before logging in merge tablets
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2906:
URL: https://github.com/apache/accumulo/pull/2906#discussion_r959521932
##########
core/src/main/java/org/apache/accumulo/core/util/Merge.java:
##########
@@ -225,8 +226,9 @@ protected void merge(AccumuloClient client, String table, List<Size> sizes, int
try {
Text start = sizes.get(0).extent.prevEndRow();
Text end = sizes.get(numToMerge - 1).extent.endRow();
- message("Merging %d tablets from (%s to %s]", numToMerge, start == null ? "-inf" : start,
- end == null ? "+inf" : end);
+ message("Merging %d tablets from (%s to %s]", numToMerge,
+ start == null ? "-inf" : Key.toPrintableString(start.getBytes(), 0, start.getLength(), end.getLength()),
Review Comment:
I believe the last parameter should be `start.getLength()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2906: convert text to printable string before logging in merge tablets
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2906:
URL: https://github.com/apache/accumulo/pull/2906#issuecomment-1234611631
Thanks for the PR @skirklin . It looks like this is your first contribution to this project. If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself (in alphabetical order) at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to `apache/accumulo#2906` in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. :smiley_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2906: convert text to printable string before logging in merge tablets
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #2906:
URL: https://github.com/apache/accumulo/pull/2906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org