You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by VK Sameer <sa...@collab.net> on 2004/12/14 07:33:57 UTC
IS_FNCHAR ok to use?
Hello,
While checking out the fix for issue 1954, Jon Foster's patch took me to
IS_FNCHAR (in include/arch/win32/apr_arch_file_io.h) for testing whether
pathnames contain invalid/reserved characters on Windows. Is it ok to
use this even though it has no APR_ prefix?
Thanks
Sameer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: IS_FNCHAR ok to use?
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Dec 2004, VK Sameer wrote:
> On Tue, 2004-12-14 at 13:55, Peter N. Lundblad wrote:
> > On Tue, 14 Dec 2004, VK Sameer wrote:
> >
> > I'm not sure I think that's a good idea.
>
> Using IS_FNCHAR or os-specific checks altogether?
>
OS-specific checks.
> > When would you do this check?
>
> It would be part of a check for os-specific characters before creating
> and adding a file in a working copy.
>
> These are the files:
> subversion/libsvn_wc/copy.c
> subversion/libsvn_wc/adm_ops.c
> subversion/libsvn_wc/update_editor.c
> subversion/libsvn_client/copy.c
>
Wouldn't that be rather useles? The OS wouldn't allow you to create such
files in the first place. Maybe some checks when checking
out/updating/exporting. I don't know if a server can use a colon in a
filename today to write to your floppy drive:-)
I this this has been disucssed before. The main reason for to including
these checks is that they must be a project policy. If you have only
Windows developers, you won't have these filenames added. If you are a
mixed environment, the ones who need the check live on that OS that allow
these characters. I think this belongs in a pre-commit hook script.
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: IS_FNCHAR ok to use?
Posted by VK Sameer <sa...@collab.net>.
On Tue, 2004-12-14 at 13:55, Peter N. Lundblad wrote:
> On Tue, 14 Dec 2004, VK Sameer wrote:
>
> > While checking out the fix for issue 1954, Jon Foster's patch took me to
> > IS_FNCHAR (in include/arch/win32/apr_arch_file_io.h) for testing whether
> > pathnames contain invalid/reserved characters on Windows. Is it ok to
> > use this even though it has no APR_ prefix?
> >
> Have we decided that we want this check inside svn at all?
I haven't brought up the proposal before. Not sure if it has been
discussed earlier.
> I'm not sure I think that's a good idea.
Using IS_FNCHAR or os-specific checks altogether?
> When would you do this check?
It would be part of a check for os-specific characters before creating
and adding a file in a working copy.
These are the files:
subversion/libsvn_wc/copy.c
subversion/libsvn_wc/adm_ops.c
subversion/libsvn_wc/update_editor.c
subversion/libsvn_client/copy.c
Regards
Sameer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: IS_FNCHAR ok to use?
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Tue, 14 Dec 2004, VK Sameer wrote:
> While checking out the fix for issue 1954, Jon Foster's patch took me to
> IS_FNCHAR (in include/arch/win32/apr_arch_file_io.h) for testing whether
> pathnames contain invalid/reserved characters on Windows. Is it ok to
> use this even though it has no APR_ prefix?
>
Have we decided that we want this check inside svn at all? I'm not sure I
think that's a good idea. When would you do this check?
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org