You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/25 03:59:06 UTC

[GitHub] [spark] MaxGekk commented on pull request #37649: [SPARK-40209][SQL] Don't change the interval value of Decimal in `changePrecision()` on errors

MaxGekk commented on PR #37649:
URL: https://github.com/apache/spark/pull/37649#issuecomment-1226744505

   > This change seems to break the design.
   
   The bad design is to leave a Decimal value in inconsistent/wrong state between invokes of Decimal methods. Seems like the current assumption is `changePrecision()` can be invoked ONLY once (since we cannot predict either the method fails or not). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org