You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by gtapper <gi...@git.apache.org> on 2016/01/29 09:10:09 UTC
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
GitHub user gtapper opened a pull request:
https://github.com/apache/incubator-trafodion/pull/294
[TRaFODION-1699] Updated web site to rely on Contributor Guide on the
wiki. Changed download to point to real binaries hosted on the
build-result site. Ran spell checks on all the guides and fixed formatting
errors as I saw then.
The *-redirect.md pages redirects Contribution and Team pages to the wiki
rather than doing a direct link. This is to allow us to track access using
Google Analytics, which is not possible with direct links to the wiki.
Also tried out Steve's new build for the web site, which works very well.
Thanks!
Please publish the documents to 2.0.0 and update the web site. The deleted
.md file can be deleted from the web site's SVN repository, too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtapper/incubator-trafodion TRAFODION-1699
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #294
----
commit 3063990dc91194c50557d1c803152a4e605f4e3c
Author: Gunnar Tapper <gt...@esgyn.local>
Date: 2016-01-29T08:02:09Z
[TRaFODION-1699] Updated web site to rely on Contributor Guide on the
wiki. Changed download to point to real binaries hosted on the
build-result site. Ran spell checks on all the guides and fixed formatting
errors as I saw then.
The *-redirect.md pages redirects Contribution and Team pages to the wiki
rather than doing a direct link. This is to allow us to track access using
Google Analytics, which is not possible with direct links to the wiki.
Also tried out Steve's new build for the web site, which works very well.
Thanks!
Please publish the documents to 2.0.0 and update the web site. The deleted
.md file can be deleted from the web site's SVN repository, too.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/294#discussion_r51448321
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_utilities.adoc ---
@@ -64,7 +64,7 @@ The Trafodion bulk load process takes place in two phases:
* _Preparation phase_: In this phase, Trafodion reads the data from
the source files in Hive or HDFS, partitions the data based on the
target table's partitioning scheme, sorts the data, and then generates
-KeyValue pairs that will populate the HFiles. Trafodion also encodes the
+Key-value pairs that will populate the HFiles. Trafodion also encodes the
--- End diff --
I suspect the old text is referring to a Java class "KeyValue" (but then "KeyValue pairs" would not be correct, "KeyValue objects" would be better). I think it is OK to change this to "key-value" (referring to a concept rather than a Java class), but in that case it shouldn't be capitalized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/294#discussion_r51446307
--- Diff: docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc ---
@@ -164,10 +164,10 @@ between 1 and the <value-2> of SELECT expressions.
== SQL 4008
```
-A subquery is not allowed inside an aggregate function.
+A sub query is not allowed inside an aggregate function.
--- End diff --
Actually, "subquery" is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/294#discussion_r51447198
--- Diff: docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc ---
@@ -1861,13 +1848,13 @@ incompatible data types.
== SQL 4128
```
-Default volume and subvolume information could not be retrieved fromc=_DEFAULTS define - DEFINEINFO error <number>.
+Default volume and sub volume information could not be retrieved from=_DEFAULTS define - DEFINEINFO error <number>.
--- End diff --
I would think subvolume would be correct, however, this message is Guardian-specific and should never occur in Trafodion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRaFODION-1699] Updated web sit...
Posted by gtapper <gi...@git.apache.org>.
Github user gtapper commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/294#discussion_r51464796
--- Diff: docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc ---
@@ -1861,13 +1848,13 @@ incompatible data types.
== SQL 4128
```
-Default volume and subvolume information could not be retrieved fromc=_DEFAULTS define - DEFINEINFO error <number>.
+Default volume and sub volume information could not be retrieved from=_DEFAULTS define - DEFINEINFO error <number>.
--- End diff --
There are bunches of those. I don't know which FS errors are and are not
used in Trafodion so I hope someone else can bring out the eraser...
On Mon, Feb 1, 2016 at 10:09 AM, DaveBirdsall <no...@github.com>
wrote:
> In docs/messages_guide/src/asciidoc/_chapters/binder_msgs.adoc
> <https://github.com/apache/incubator-trafodion/pull/294#discussion_r51447198>
> :
>
> > @@ -1861,13 +1848,13 @@ incompatible data types.
> > == SQL 4128
> >
> > ```
> > -Default volume and subvolume information could not be retrieved fromc=_DEFAULTS define - DEFINEINFO error <number>.
> > +Default volume and sub volume information could not be retrieved from=_DEFAULTS define - DEFINEINFO error <number>.
>
> I would think subvolume would be correct, however, this message is
> Guardian-specific and should never occur in Trafodion.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-trafodion/pull/294/files#r51447198>.
>
--
Thanks,
Gunnar
*If you think you can you can, if you think you can't you're right.*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---