You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/02/09 20:59:37 UTC
[GitHub] [hadoop] steveloughran opened a new pull request #1839:
HADOOP-16848. Refactoring: initial layering
steveloughran opened a new pull request #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839
First PoC of My planned layout model of the S3A FS.
* There's a raw layer and a guarded layer
* which are instantiated in sequence in a separate executor from S3AFileSystem.initalize
And whose accessors block until completed or rethrow failures.
The layers are being handed in all their dependencies from FS.initialize()
and we currently block until started.
What I plan to do, in a future iteration, is:
* each layer extracts their own settings from the config and stores locally
(list version, upload size etc)
* have each layer instantiate their internal classes (AWS S3 client, transfer manager) internally
* Also async create: metastore, DT binding
* And all startup actions (check bucket, init multipart, ...)
Then
* move ops to the layers, raw* -> rawStore; inner -> S3AStore
* move WriteOperationHelper, SelectBinding, etc, to all work against S3AStore rather than FS.
S3AStore will become where most of the code moves to; S3AFilesystem more of the init and binding to hadoop FS API.
RawS3A will be the accessor through which all AWS client access goes.
Not going to change: all accessors on S3AFileSystem...not just tests use it but some external code (cloudstore) needs it to get at low level S3A, etc.
Change-Id: I998c0d61cce2ee7fd0be804bf21da6b68fd69a6f
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1839: HADOOP-16848.
Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-583900610
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 26s | root in trunk failed. |
| -1 :x: | compile | 0m 28s | root in trunk failed. |
| -0 :warning: | checkstyle | 2m 58s | The patch fails to run checkstyle in root |
| -1 :x: | mvnsite | 0m 59s | hadoop-aws in trunk failed. |
| -1 :x: | shadedclient | 10m 39s | branch has errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 31s | trunk passed |
| +0 :ok: | spotbugs | 1m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 6s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 54s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 29s | hadoop-aws in the patch failed. |
| -1 :x: | compile | 16m 23s | root in the patch failed. |
| -1 :x: | javac | 16m 23s | root in the patch failed. |
| -0 :warning: | checkstyle | 2m 37s | root: The patch generated 36 new + 0 unchanged - 0 fixed = 36 total (was 0) |
| -1 :x: | mvnsite | 0m 47s | hadoop-aws in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 19s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 43s | the patch passed |
| -1 :x: | findbugs | 0m 47s | hadoop-aws in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 37s | hadoop-common in the patch passed. |
| -1 :x: | unit | 0m 47s | hadoop-aws in the patch failed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 78m 12s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFsTrash |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e7211e3ac278 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6191d4b |
| Default Java | 1.8.0_242 |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1839/out/maven-branch-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-mvnsite-hadoop-tools_hadoop-aws.txt |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/diff-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/testReport/ |
| Max. process+thread count | 1378 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1839: HADOOP-16848.
Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-588225353
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 7s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 20s | trunk passed |
| +1 :green_heart: | compile | 17m 2s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 37s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 20s | trunk passed |
| +1 :green_heart: | shadedclient | 20m 31s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 43s | trunk passed |
| +0 :ok: | spotbugs | 1m 11s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 16s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 27s | hadoop-aws in the patch failed. |
| -1 :x: | compile | 15m 31s | root in the patch failed. |
| -1 :x: | javac | 15m 31s | root in the patch failed. |
| -0 :warning: | checkstyle | 2m 40s | root: The patch generated 43 new + 31 unchanged - 0 fixed = 74 total (was 31) |
| -1 :x: | mvnsite | 0m 49s | hadoop-aws in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 25s | patch has no errors when building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 37s | hadoop-tools_hadoop-aws generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) |
| -1 :x: | findbugs | 0m 35s | hadoop-aws in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 9m 46s | hadoop-common in the patch passed. |
| -1 :x: | unit | 0m 35s | hadoop-aws in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 120m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 404ab7a7b7be 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / cb3f3cc |
| Default Java | 1.8.0_242 |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/diff-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt |
| javadoc | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/diff-javadoc-javadoc-hadoop-tools_hadoop-aws.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/testReport/ |
| Max. process+thread count | 3206 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/2/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on issue #1839: HADOOP-16848.
Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
steveloughran commented on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-583892914
FYI @bgaborg @sidseth
not quite ready for review, but you get the idea. Split up the S3AFileSystem class into layers with interface and impl, async chained init from S3A FS, which creates them, knows about DelegationTokens, and how to bind its operations to the store
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus removed a comment on issue #1839:
HADOOP-16848. Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
hadoop-yetus removed a comment on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-583900610
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 30s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 26s | root in trunk failed. |
| -1 :x: | compile | 0m 28s | root in trunk failed. |
| -0 :warning: | checkstyle | 2m 58s | The patch fails to run checkstyle in root |
| -1 :x: | mvnsite | 0m 59s | hadoop-aws in trunk failed. |
| -1 :x: | shadedclient | 10m 39s | branch has errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 31s | trunk passed |
| +0 :ok: | spotbugs | 1m 15s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 6s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 54s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 29s | hadoop-aws in the patch failed. |
| -1 :x: | compile | 16m 23s | root in the patch failed. |
| -1 :x: | javac | 16m 23s | root in the patch failed. |
| -0 :warning: | checkstyle | 2m 37s | root: The patch generated 36 new + 0 unchanged - 0 fixed = 36 total (was 0) |
| -1 :x: | mvnsite | 0m 47s | hadoop-aws in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 19s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 43s | the patch passed |
| -1 :x: | findbugs | 0m 47s | hadoop-aws in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 37s | hadoop-common in the patch passed. |
| -1 :x: | unit | 0m 47s | hadoop-aws in the patch failed. |
| +1 :green_heart: | asflicense | 0m 52s | The patch does not generate ASF License warnings. |
| | | 78m 12s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.viewfs.TestViewFsTrash |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e7211e3ac278 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6191d4b |
| Default Java | 1.8.0_242 |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out//home/jenkins/jenkins-slave/workspace/hadoop-multibranch_PR-1839/out/maven-branch-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/branch-mvnsite-hadoop-tools_hadoop-aws.txt |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/diff-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/testReport/ |
| Max. process+thread count | 1378 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1839: HADOOP-16848.
Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-593942273
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 7s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 18m 54s | trunk passed |
| +1 :green_heart: | compile | 17m 5s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 36s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 19s | trunk passed |
| +1 :green_heart: | shadedclient | 20m 9s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 44s | trunk passed |
| +0 :ok: | spotbugs | 1m 12s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 16s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 28s | hadoop-aws in the patch failed. |
| -1 :x: | compile | 15m 22s | root in the patch failed. |
| -1 :x: | javac | 15m 22s | root in the patch failed. |
| -0 :warning: | checkstyle | 2m 41s | root: The patch generated 41 new + 31 unchanged - 0 fixed = 72 total (was 31) |
| -1 :x: | mvnsite | 0m 48s | hadoop-aws in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 6s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 43s | the patch passed |
| -1 :x: | findbugs | 0m 46s | hadoop-aws in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 30s | hadoop-common in the patch passed. |
| -1 :x: | unit | 0m 48s | hadoop-aws in the patch failed. |
| +1 :green_heart: | asflicense | 0m 51s | The patch does not generate ASF License warnings. |
| | | 119m 52s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.shell.TestCopy |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux ee0a173a422e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / c0d0842 |
| Default Java | 1.8.0_242 |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/diff-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/testReport/ |
| Max. process+thread count | 2517 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1839: HADOOP-16848.
Refactoring: initial layering
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1839: HADOOP-16848. Refactoring: initial layering
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-593629160
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 25m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 1m 10s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 19m 22s | trunk passed |
| +1 :green_heart: | compile | 16m 49s | trunk passed |
| +1 :green_heart: | checkstyle | 2m 37s | trunk passed |
| +1 :green_heart: | mvnsite | 2m 18s | trunk passed |
| +1 :green_heart: | shadedclient | 20m 47s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 45s | trunk passed |
| +0 :ok: | spotbugs | 1m 10s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 12s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 19s | hadoop-aws in the patch failed. |
| -1 :x: | compile | 15m 25s | root in the patch failed. |
| -1 :x: | javac | 15m 25s | root in the patch failed. |
| -0 :warning: | checkstyle | 2m 40s | root: The patch generated 42 new + 31 unchanged - 0 fixed = 73 total (was 31) |
| -1 :x: | mvnsite | 0m 35s | hadoop-aws in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 47s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 34s | the patch passed |
| -1 :x: | findbugs | 0m 35s | hadoop-aws in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 9m 36s | hadoop-common in the patch passed. |
| -1 :x: | unit | 0m 33s | hadoop-aws in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 145m 32s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.fs.shell.TestCopy |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 395a70bf17f6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / edc2e9d |
| Default Java | 1.8.0_242 |
| mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-mvninstall-hadoop-tools_hadoop-aws.txt |
| compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-compile-root.txt |
| javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-compile-root.txt |
| checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/diff-checkstyle-root.txt |
| mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-mvnsite-hadoop-tools_hadoop-aws.txt |
| findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-findbugs-hadoop-tools_hadoop-aws.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt |
| unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt |
| Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/testReport/ |
| Max. process+thread count | 1535 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1839/3/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org