[jira] [Commented] (HBASE-13368) Hash.java is declared as public Interface - but it should be Private

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389959#comment-14389959 ] 

Enis Soztutar commented on HBASE-13368:
---------------------------------------

I wanted to get all XXHash classes private. But there was a review comment about keeping them Public. Not sure whether it applies to Hash as well. i think it is fine to do it Private. 

> Hash.java is declared as public Interface - but it should be Private
> --------------------------------------------------------------------
>
>                 Key: HBASE-13368
>                 URL: https://issues.apache.org/jira/browse/HBASE-13368
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 1.1.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Trivial
>         Attachments: HBASE-13368.patch, HBASE-13368_1.patch
>
>
> Currently Hash.java is marked as public.  But we are not allowing the user to configure his own Hash.java impl using FQCN.  It is currently working as an enum based type.  
> So this class should be an Private interface and not a direct user facing interface. Thanks to Anoop for confirming on this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)