You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/07 17:26:54 UTC
[GitHub] [incubator-mxnet] olk opened a new pull request #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
olk opened a new pull request #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543
- using nullptr is more explicit
- macro NULL can be a integer literal with value zero (since C++11)
- literal nullptr is of type std::nullptr_t
- as template arg NULL and 0 evaluate to integer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu merged pull request #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] olk edited a comment on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583719868
windows-gpu job fails with:
>
> [2020-02-08T07:58:57.240Z] test_operator_gpu.test_rnnrelu_dropout ...
> [2020-02-08T07:58:59.749Z] Error running tests, python exited with status code C0000374
> [2020-02-08T07:58:59.749Z] At C:\jenkins_slave\workspace\ut-python-gpu\ci\windows\test_py3_gpu.ps1:30
> [2020-02-08T07:58:59.749Z] char:13
> [2020-02-08T07:58:59.749Z] + if (! $?) { Throw ("Error running tests, python exited with status co ...
> [2020-02-08T07:58:59.749Z] + CategoryInfo : OperationStopped: (Error running t...s code C0000374:String) [], RuntimeException
> [2020-02-08T07:58:59.749Z] + FullyQualifiedErrorId : Error running tests, python exited with status code C0000374
I can't imagine that this failure is caused by the nullptr patch.
exception **C0000374** == [Heap Corruption Exception 0xC0000374](https://docs.microsoft.com/en-us/archive/blogs/calvin_hsia/heap-corruption-exception-0xc0000374)
Maybe **Application Verfier** (appverif.exe) could help to locate the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] olk edited a comment on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583536506
Jenkins job related to website (Julia docu) fails because of invalid markdown version:
> [2020-02-07T17:50:14.697Z] pkg_resources.VersionConflict: (Markdown 3.2 (/home/jenkins_slave/.local/lib/python3.5/site-packages), Requirement.parse('markdown<3.2'))
> [2020-02-07T17:50:14.697Z] Makefile:19: recipe for target 'all' failed
> [2020-02-07T17:50:14.697Z] make: Leaving directory '/work/mxnet/julia/docs'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] olk commented on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
olk commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583536506
Jenkins job related to website (Julia docu) fails because of :
> [2020-02-07T17:50:14.697Z] pkg_resources.VersionConflict: (Markdown 3.2 (/home/jenkins_slave/.local/lib/python3.5/site-packages), Requirement.parse('markdown<3.2'))
> [2020-02-07T17:50:14.697Z] Makefile:19: recipe for target 'all' failed
> [2020-02-07T17:50:14.697Z] make: Leaving directory '/work/mxnet/julia/docs'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583548206
Julia issue tracked at https://github.com/apache/incubator-mxnet/issues/16146. You can ignore that issue for now. Just make sure all other CI steps pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] olk edited a comment on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
olk edited a comment on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583719868
windows-gpu job fails with:
>
> [2020-02-08T07:58:57.240Z] test_operator_gpu.test_rnnrelu_dropout ...
> [2020-02-08T07:58:59.749Z] Error running tests, python exited with status code C0000374
> [2020-02-08T07:58:59.749Z] At C:\jenkins_slave\workspace\ut-python-gpu\ci\windows\test_py3_gpu.ps1:30
> [2020-02-08T07:58:59.749Z] char:13
> [2020-02-08T07:58:59.749Z] + if (! $?) { Throw ("Error running tests, python exited with status co ...
> [2020-02-08T07:58:59.749Z] + CategoryInfo : OperationStopped: (Error running t...s code C0000374:String) [], RuntimeException
> [2020-02-08T07:58:59.749Z] + FullyQualifiedErrorId : Error running tests, python exited with status code C0000374
I can't imagine that this failure is caused by the nullptr patch.
exception **C0000374** == [Heap Corruption Exception 0xC0000374](https://docs.microsoft.com/en-us/archive/blogs/calvin_hsia/heap-corruption-exception-0xc0000374)
Maybe **Application Verfier** (appverif.exe) could help to locate the error.
Unfortunately I can't debug it on Windows because by dev platform is Linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] leezu commented on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583548416
You don't need to close / open new PRs to retrigger CI. Whenever you push a new commit, CI will rerun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] olk commented on issue #17543:
MXNET-1444/MXNET-1445: replace NULL by nullptr
Posted by GitBox <gi...@apache.org>.
olk commented on issue #17543: MXNET-1444/MXNET-1445: replace NULL by nullptr
URL: https://github.com/apache/incubator-mxnet/pull/17543#issuecomment-583719868
windows-gpu job fails with:
>
> [2020-02-08T07:58:57.240Z] test_operator_gpu.test_rnnrelu_dropout ...
> [2020-02-08T07:58:59.749Z] Error running tests, python exited with status code C0000374
> [2020-02-08T07:58:59.749Z] At C:\jenkins_slave\workspace\ut-python-gpu\ci\windows\test_py3_gpu.ps1:30
> [2020-02-08T07:58:59.749Z] char:13
> [2020-02-08T07:58:59.749Z] + if (! $?) { Throw ("Error running tests, python exited with status co ...
> [2020-02-08T07:58:59.749Z] + CategoryInfo : OperationStopped: (Error running t...s code C000
> [2020-02-08T07:58:59.749Z] 0374:String) [], RuntimeException
> [2020-02-08T07:58:59.749Z] + FullyQualifiedErrorId : Error running tests, python exited with status code C0000374
I can't imagine that this failure is caused by the nullptr patch.
exception **C0000374** == [Heap Corruption Exception 0xC0000374](https://docs.microsoft.com/en-us/archive/blogs/calvin_hsia/heap-corruption-exception-0xc0000374)
Maybe **Application Verfier** (appverif.exe) could help to locate the error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services