You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/04 15:40:06 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9882: ARROW-12190: [Rust][DataFusion] Implement parallel / partitioned hash join

jorgecarleitao commented on a change in pull request #9882:
URL: https://github.com/apache/arrow/pull/9882#discussion_r606818340



##########
File path: rust/benchmarks/src/bin/tpch.rs
##########
@@ -1677,7 +1677,6 @@ mod tests {
             let actual_vec = result_vec(&actual);
 
             // basic result comparison
-            assert_eq!(expected_vec.len(), actual_vec.len());

Review comment:
       Just curious: Is there a reason to remove this? The next `for` loop does not check the results' lens (i.e. if `actual_vec.len() < expected_vec.len()` and has equal rows, then the check passes).
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org