[GitHub] spark pull request: [SPARK-3609][SQL] Adds sizeInBytes statistics ...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2468#discussion_r17813850
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ---
    @@ -649,28 +650,43 @@ class SQLQuerySuite extends QueryTest with BeforeAndAfterAll {
           (3, null) ::
           (4, 2147483644) :: Nil)
       }
    -  
    +
       test("SPARK-3423 BETWEEN") {
         checkAnswer(
           sql("SELECT key, value FROM testData WHERE key BETWEEN 5 and 7"),
           Seq((5, "5"), (6, "6"), (7, "7"))
         )
    -    
    +
         checkAnswer(
           sql("SELECT key, value FROM testData WHERE key BETWEEN 7 and 7"),
           Seq((7, "7"))
         )
    -    
    +
         checkAnswer(
           sql("SELECT key, value FROM testData WHERE key BETWEEN 9 and 7"),
           Seq()
         )
       }
    -    
    +
       test("cast boolean to string") {
         // TODO Ensure true/false string letter casing is consistent with Hive in all cases.
         checkAnswer(
           sql("SELECT CAST(TRUE AS STRING), CAST(FALSE AS STRING) FROM testData LIMIT 1"),
           ("true", "false") :: Nil)
       }
    +
    +  test("Limit sizeInBytes estimation") {
    --- End diff --
    
    This probably belongs in PlannerSuite.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org