You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zhipwang <gi...@git.apache.org> on 2016/01/16 05:17:27 UTC
[GitHub] spark pull request: RoutingTablePartition code comment errors
GitHub user zhipwang opened a pull request:
https://github.com/apache/spark/pull/10783
RoutingTablePartition code comment errors
There is an error in description of RoutingTablePartition object. The "edge partition" is encoded in the lower 30 bits of the Int, not 30 bytes of the Int. And the same mistake is made in "position is encoded in the upper 2 bytes of the Int".
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhipwang/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10783.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10783
----
commit e571bbdca32321e9fbda30dfb55ce518fa372d5c
Author: zhipwang <wz...@gmail.com>
Date: 2016-01-16T04:06:08Z
RoutingTablePartition comment error
There is an error in description of RoutingTablePartition object. The "edge partition" is encoded in the lower 30 bits of the Int, not 30 bytes of the Int. And the same mistake is made in "position is encoded in the upper 2 bytes of the Int".
commit 214d35250ea683d81e799978776beb8499615a20
Author: zhipwang <wz...@gmail.com>
Date: 2016-01-16T04:16:19Z
Merge pull request #1 from zhipwang/graphx_RoutingTablePartition_comment_error_zhipwang
RoutingTablePartition comment error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by zhipwang <gi...@git.apache.org>.
Github user zhipwang commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172474130
I'm not quite sure but I can't make another PR while keeping this one. I will close it and try a new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172369195
I got the same problem. I'll try to figure out why...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by zhipwang <gi...@git.apache.org>.
Github user zhipwang closed the pull request at:
https://github.com/apache/spark/pull/10783
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172175602
**[Test build #2388 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2388/consoleFull)** for PR 10783 at commit [`214d352`](https://github.com/apache/spark/commit/214d35250ea683d81e799978776beb8499615a20).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by zhipwang <gi...@git.apache.org>.
Github user zhipwang commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172453659
Should I close it and make a new PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172369038
@srowen Sure, I'll try merging it with master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172174891
OK, that's fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by zhipwang <gi...@git.apache.org>.
Github user zhipwang commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172471402
OK~ I will keep this and open a new one. Thanks~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172155624
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172459611
You should not need to, however I still don't see why this does not merge. In the past I recall something like this happened when the PR description had some certain funny characters. I don't see them here and thought the script was improved. You could try taking out the quotes in the description since they become part of the git command line, but really that should not be a problem. You could try another PR too just to see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: RoutingTablePartition code comment errors
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10783#issuecomment-172368755
@vanzin @jkbradley can any of you try merging this? git keeps failing when I try and I don't see why. Just "error code 1". Looks entirely mergeable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org