[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1040: [MNG-7720] Wrong build order of forked projects

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #1040:
URL: https://github.com/apache/maven/pull/1040#discussion_r1128339820


##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleDependencyResolver.java:
##########
@@ -90,7 +90,11 @@ public LifecycleDependencyResolver(
 
     public static List<MavenProject> getProjects(MavenProject project, MavenSession session, boolean aggregator) {
         if (aggregator && project.getCollectedProjects() != null) {

Review Comment:
   Here we have check `project.getCollectedProjects() != null` 
   but in method `getProjectAndSubModules` we list project `recursively` and we don't check if subproject has `getCollectedProjects() != null` - it is ok? line 102/106



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org