You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/09 06:09:31 UTC

[GitHub] [maven-doxia-sitetools] michael-o commented on a diff in pull request #39: Remove default (bundled) skin

michael-o commented on code in PR #39:
URL: https://github.com/apache/maven-doxia-sitetools/pull/39#discussion_r867658804


##########
doxia-integration-tools/src/main/resources/default-site.xml:
##########
@@ -22,6 +22,11 @@ under the License.
   <bannerLeft>
     <name>${project.name}</name>
   </bannerLeft>
+  <skin>

Review Comment:
   One of the goals is to evaluate whether the bundled skin can be removed to remove duplication between default and Fluido. Moreover, it will only be used if a site.xml has not been provided. Otherwise you need to provide one. This PR is incomplete because a few tests need to be fixed. Default and Fluido share 60% of the code, consider the maintenance work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org