[GitHub] [libcloud] Kami commented on pull request #1656: Add support for eu-south-1 in EC2 and VCloud accept version

[GitBox <gi...@apache.org>]

Kami commented on pull request #1656:
URL: https://github.com/apache/libcloud/pull/1656#issuecomment-1057354000


   It looks like a unit test is failing and a bunch of lint checks are also failing:
   
   ```bash
   libcloud/compute/constants/ec2_instance_types.py:2706:5: F601 dictionary key 'c6i.12xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2740:5: F601 dictionary key 'c6i.16xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2775:5: F601 dictionary key 'c6i.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2810:5: F601 dictionary key 'c6i.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2845:5: F601 dictionary key 'c6i.32xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2879:5: F601 dictionary key 'c6i.4xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2914:5: F601 dictionary key 'c6i.8xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2948:5: F601 dictionary key 'c6i.large' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:2982:5: F601 dictionary key 'c6i.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3017:5: F601 dictionary key 'c6i.12xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3052:5: F601 dictionary key 'c6i.16xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3087:5: F601 dictionary key 'c6i.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3122:5: F601 dictionary key 'c6i.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3157:5: F601 dictionary key 'c6i.32xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3192:5: F601 dictionary key 'c6i.4xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3227:5: F601 dictionary key 'c6i.8xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3261:5: F601 dictionary key 'c6i.large' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3295:5: F601 dictionary key 'c6i.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3874:5: F601 dictionary key 'dl1.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:3908:5: F601 dictionary key 'dl1.24xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4292:5: F601 dictionary key 'g4ad.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4327:5: F601 dictionary key 'g4ad.2xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4434:5: F601 dictionary key 'g4ad.xlarge' repeated with different values
   libcloud/compute/constants/ec2_instance_types.py:4469:5: F601 dictionary key 'g4ad.xlarge' repeated with different values
   ```
   
   I will try to get that sorted out and merge the PR into trunk. Thanks for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org