You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/06 10:39:24 UTC

[GitHub] [spark] beliefer commented on a change in pull request #24308: [SPARK-27397[Core] Take care of OpenJ9 JVM in Spark

beliefer commented on a change in pull request #24308: [SPARK-27397[Core] Take care of OpenJ9 JVM in Spark
URL: https://github.com/apache/spark/pull/24308#discussion_r272791818
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
 ##########
 @@ -131,8 +131,9 @@ object SizeEstimator extends Logging {
       return System.getProperty(TEST_USE_COMPRESSED_OOPS_KEY).toBoolean
     }
 
-    // java.vm.info provides compressed ref info for IBM JDKs
-    if (System.getProperty("java.vendor").contains("IBM")) {
+    // java.vm.info provides compressed ref info for IBM and OpenJ9 JDKs
+    if (System.getProperty("java.vendor").contains("IBM") ||
 
 Review comment:
   It seems that "IBM" and "OpenJ9" have similar information about compression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org