[jira] [Commented] (KARAF-5297) Cave proxy repository that requires authentication

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251422#comment-16251422 ] 

ASF GitHub Bot commented on KARAF-5297:
---------------------------------------

jbonofre commented on issue #5: [KARAF-5297] Allow cave proxy and populate repository for URLs with authorization
URL: https://github.com/apache/karaf-cave/pull/5#issuecomment-344270780
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cave proxy repository that requires authentication
> --------------------------------------------------
>
>                 Key: KARAF-5297
>                 URL: https://issues.apache.org/jira/browse/KARAF-5297
>             Project: Karaf
>          Issue Type: Improvement
>          Components: cave-repository
>    Affects Versions: cave-4.0.0
>         Environment: macOS Sierra 10.12.6, Karaf 4.1.1
>            Reporter: Ankit Dangi
>            Assignee: Jean-Baptiste Onofré
>             Fix For: cave-4.1.0
>
>
> Let's say, we're proxying an external repository in Karaf Cave to use as an OBR: 
> {{karaf@root()> cave:repository-proxy my-repository maven_repository_url}}
> If this external {{maven_repository_url}} requires authentication in the HTTP mode (and not HTTPS), then the error is: {{"Error executing command: Server returned HTTP response code: 401 for URL: maven_repository_url"}}. 
> Improvement: Requesting an appropriate option (like "{{--filter}}") for {{cave:repository-proxy}} support for proxying a repository that requires authentication. 
> Changes would mostly be at these locations: 
> 1. {{karaf-cave/server/command/src/.../RepositoryProxyCommand.java}} [Link: [http://bit.ly/2fqUbgD]]
> 2. {{karaf-cave/server/storage/src/.../CaveRepositoryImpl.java}}, Update method: {{proxyHttp(...)}} [Link: [http://bit.ly/2wrwQiS]]
> Also, in 2 above, replace the deprecated {{DefaultHttpClient}} with {{HttpClientBuilder}}. 
> However, if the {{proxy(...)}} parameters are changed, then, it may require changes at other places, such as:
> i. {{karaf-cave/server/api/src/.../CaveRepository.java}}, Overload method: {{proxy(...)}} [Link: [http://bit.ly/2vh6bXa]]
> ii. {{karaf-cave/server/storage/src/.../CaveRepositoryImpl.java}}, Overload method: {{proxy(...)}} [Link: [http://bit.ly/2uDu2Nt]]
> iii. {{karaf-cave/server/management/src/.../CaveRepositoryMBean.java}} [Link: [http://bit.ly/2uDxUy2]]
> iv. {{karaf-cave/server/management/src/.../CaveRepositoryMBeanImpl.java}} [Link: [http://bit.ly/2wFG2zj]]
> v. {{karaf-cave/manual/src/.../administrate-cave.conf}} [Link: [http://bit.ly/2wr4SDX]]
> Any other places? Search: [http://bit.ly/2fr4qkQ].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)