You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2008/03/06 17:43:02 UTC

[jira] Resolved: (HARMONY-5578) [classlib][pack200] Remove regex dependency of Pack200

     [ https://issues.apache.org/jira/browse/HARMONY-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January resolved HARMONY-5578.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0M6

Applied patch in r634338.  Please check that the patch was applied as you expected.

> [classlib][pack200] Remove regex dependency of Pack200
> ------------------------------------------------------
>
>                 Key: HARMONY-5578
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5578
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>            Priority: Minor
>             Fix For: 5.0M6
>
>         Attachments: main.patch, test.patch
>
>
> I've had a complaint that my Pack200 code depends on regex being available because I use String.matches(). In some cases, regex may not be available - and it really doesn't make sense to use the overhead of regex when I don't need to. So I've added the worlds worst regex replacement to SegmentConstantPool so the dependency isn't there.
> This patch also removes a few magic values from SegmentConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.