You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/09 20:43:51 UTC

[GitHub] [hbase-native-client] phrocker commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

phrocker commented on a change in pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r452478797



##########
File path: CMakeLists.txt
##########
@@ -117,23 +124,22 @@ endif()
 
 include_directories("${JAVA_HBASE_DIR}/hbase-common/target/generated-sources/native/")
 ############
-## Validate that we have C++ 14 support
+## Validate that we have C++ 17 support

Review comment:
       Yes my hope was to move forward as it would support optional. In retrospect after a nice break from computers and a week off I don't want to push for this change without a lot more testing. I will revert this part of the change. I've grown fond of c++17, but I think you'd agree it's an unnecessary change at this time. Thanks for your patience and help!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org