You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by 3Dragan <gi...@git.apache.org> on 2015/09/25 18:44:22 UTC
[GitHub] storm pull request: [STORM-123], add check case for external chang...
GitHub user 3Dragan opened a pull request:
https://github.com/apache/storm/pull/763
[STORM-123], add check case for external change of 'now' value.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/3Dragan/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #763
----
commit 7d5285545a4d4f227f7f8616c2f769f055649560
Author: ddragan <dm...@gmail.com>
Date: 2015-09-25T14:58:07Z
[STORM-123], add check case for external change of 'now' value.
commit cc082aa93e5da92c4c3f635420fabf8bb6e60bf3
Author: dragan <dm...@gmail.com>
Date: 2015-09-25T16:37:50Z
add a comment description
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-123], add check case for external chang...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-143284972
My only comment is that STORM-123 is a different JIRA associated with Nimbus HA. Could you rename it to point to the JIRA you filed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-123], add check case for external chang...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-143283874
It looks good to me I am +1 on the change, but I would like to hear from others too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1069], add check case for external chan...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-144071299
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1069], add check case for external chan...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-143787228
Looks good. I am +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1069], add check case for external chan...
Posted by 3Dragan <gi...@git.apache.org>.
Github user 3Dragan commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-143292866
Sure, my fault)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1069], add check case for external chan...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/763#issuecomment-143310184
+1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1069], add check case for external chan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---