[arrow] branch master updated: ARROW-2977: [Packaging] Release verification script should check rust too

[we...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 8cbaf44  ARROW-2977: [Packaging] Release verification script should check rust too
8cbaf44 is described below

commit 8cbaf44efa9ffae4cdbaf5ed2fa1144aff74057d
Author: Krisztián Szűcs <sz...@gmail.com>
AuthorDate: Sun Aug 5 16:06:04 2018 -0400

    ARROW-2977: [Packaging] Release verification script should check rust too
    
    I've found a couple of issues with the verification scripts:
    1. The standalone js verification script seems obsolete
    2. The windows script only checks arrow-cpp, parquet-cpp and pyarrow
    3. The windows script doesn't create conda env
    
    For the next release it'd nice to have consistent scripts on each platform (c_glib requires additional configuration on OSX).
    
    Author: Krisztián Szűcs <sz...@gmail.com>
    
    Closes #2369 from kszucs/ARROW-2977 and squashes the following commits:
    
    5e323c9b <Krisztián Szűcs> remove comments
    a59ca508 <Krisztián Szűcs> setup rustup and test rust library
---
 dev/release/verify-release-candidate.sh | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index 74ec61c..eedec46 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -225,6 +225,29 @@ test_js() {
   popd
 }
 
+test_rust() {
+  # install rust toolchain in a similar fashion like test-miniconda
+  export RUSTUP_HOME=`pwd`/test-rustup
+  export CARGO_HOME=`pwd`/test-rustup
+
+  curl https://sh.rustup.rs -sSf | sh -s -- -y
+  source $RUSTUP_HOME/env
+
+  # build and test rust
+  pushd rust
+
+  # raises on any formatting errors (disabled, because RC1 has a couple)
+  # rustup component add rustfmt-preview
+  # cargo fmt --all -- --check
+  # raises on any warnings
+  cargo rustc -- -D warnings
+
+  cargo build
+  cargo test
+
+  popd
+}
+
 # Build and test Java (Requires newer Maven -- I used 3.3.9)
 
 test_package_java() {
@@ -286,6 +309,7 @@ test_integration
 test_glib
 install_parquet_cpp
 test_python
+test_rust
 
 echo 'Release candidate looks good!'
 exit 0