You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/13 02:23:29 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #12134: ARROW-13617: [C++] Make Decimal representations consistent

cyb70289 commented on a change in pull request #12134:
URL: https://github.com/apache/arrow/pull/12134#discussion_r783582080



##########
File path: cpp/src/arrow/util/basic_decimal.cc
##########
@@ -1391,4 +1347,8 @@ BasicDecimal256 operator/(const BasicDecimal256& left, const BasicDecimal256& ri
   return result;
 }
 
+// Explicitly instantiate template base class, for DLL linking on Windows

Review comment:
       Does this approach avoid putting all template class implementation code inside the header?

##########
File path: cpp/src/arrow/util/basic_decimal.h
##########
@@ -37,50 +38,116 @@ enum class DecimalStatus {
   kRescaleDataLoss,
 };
 
+template <typename Derived, int BIT_WIDTH, int NWORDS = BIT_WIDTH / 64>

Review comment:
       Looks `Derived` is not used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org