You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by Robert Liguori <ro...@gmail.com> on 2010/10/14 16:53:17 UTC

Apache CXF and FindBugs

I see that CXF makes use of PMD and Checkstyle (
http://cxf.apache.org/coding-guidelines.html).

Any reason why CXF doesn't make use of FindBugs? -
http://findbugs.sourceforge.net/

Thanks.

Re: Apache CXF and FindBugs

Posted by Robert Liguori <ro...@gmail.com>.
Just FYI...
http://www.sonarsource.org/what-makes-checkstyle-pmd-findbugs-and-macker-complementary/

On Fri, Oct 15, 2010 at 9:09 AM, Daniel Kulp <dk...@apache.org> wrote:

> On Friday 15 October 2010 4:33:17 am Ioannis Mavroukakis wrote:
> > Is this due to lack of time/hardware? If so I have a hosted box that's
> > mostly idle and I have some time on my hands:)
>
> From Apache's perspective,there were a bunch of issues.   For one, they
> were
> trying to tie it into the Hudson instance, but the Hudson instance we have
> is
> already overloaded.   Second, they didn't want to run another database on
> the
> hudson box (again, overloaded) that Sonar needed, so they tried running it
> elsewhere, but the connection between the Hudson machines and that machine
> caused too many timeouts and such.   Then there was the issue of the Hudson
> admins not really wanting to also have to be Sonar admins and such.
> Basically, I think the approach was all wrong.   :-)
>
> One option that I would welcome people to explore is to just contact the
> Sonar
> folks on their list and ask what it would take to be able to get an "admin"
> account to admin the CXF/Camel/etc... projects on their Sonar instance.
> They
> might be completely open to it.  Doesn't hurt to ask.   :-)    If they say
> no,
> then worry about setting something up.
>
> Dan
>
>
> >
> > On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
> > > was talk of setting up a Sonar instance in Apache that we could
> > > completely setup and control, just never seemed to have happened.
> > >
> > > I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF,
> > > it would take quite a bit of work to get it to a point like where we
> are
> > > with Checkstyle/PMD.   The starting point would need to be setting up a
> > > profile to run it, then use that to find tune a config file for it that
> > > sets up reasonable sets of issues, and then fix the issues.  Patches
> > > welcome! :-)
> > >
> > > Dan
> > >
> > >> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org>
> wrote:
> > >>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
> > >>>> I see that CXF makes use of PMD and Checkstyle (
> > >>>> http://cxf.apache.org/coding-guidelines.html).
> > >>>>
> > >>>> Any reason why CXF doesn't make use of FindBugs? -
> > >>>> http://findbugs.sourceforge.net/
> > >>>
> > >>> Most likely, no one really pursued it.   Again, fixing issues that it
> > >>> finds is another valuable contribution.
> > >>>
> > >>> --
> > >>> Daniel Kulp
> > >>> dkulp@apache.org
> > >>> http://dankulp.com/blog
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://dankulp.com/blog
>

Re: Apache CXF and FindBugs

Posted by Ioannis Mavroukakis <im...@gameaccount.com>.
Hi Daniel,
I can certainly ask, if not I already have a Hudson instance running on my box. 
Y. 

On 15 Oct 2010, at 14:09, Daniel Kulp <dk...@apache.org> wrote:

> On Friday 15 October 2010 4:33:17 am Ioannis Mavroukakis wrote:
>> Is this due to lack of time/hardware? If so I have a hosted box that's
>> mostly idle and I have some time on my hands:)
> 
> From Apache's perspective,there were a bunch of issues.   For one, they were 
> trying to tie it into the Hudson instance, but the Hudson instance we have is 
> already overloaded.   Second, they didn't want to run another database on the 
> hudson box (again, overloaded) that Sonar needed, so they tried running it 
> elsewhere, but the connection between the Hudson machines and that machine 
> caused too many timeouts and such.   Then there was the issue of the Hudson 
> admins not really wanting to also have to be Sonar admins and such.   
> Basically, I think the approach was all wrong.   :-)
> 
> One option that I would welcome people to explore is to just contact the Sonar 
> folks on their list and ask what it would take to be able to get an "admin" 
> account to admin the CXF/Camel/etc... projects on their Sonar instance.   They  
> might be completely open to it.  Doesn't hurt to ask.   :-)    If they say no, 
> then worry about setting something up.
> 
> Dan
> 
> 
>> 
>> On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
>>> was talk of setting up a Sonar instance in Apache that we could
>>> completely setup and control, just never seemed to have happened.
>>> 
>>> I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF,
>>> it would take quite a bit of work to get it to a point like where we are
>>> with Checkstyle/PMD.   The starting point would need to be setting up a
>>> profile to run it, then use that to find tune a config file for it that
>>> sets up reasonable sets of issues, and then fix the issues.  Patches
>>> welcome! :-)
>>> 
>>> Dan
>>> 
>>>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>>>> I see that CXF makes use of PMD and Checkstyle (
>>>>>> http://cxf.apache.org/coding-guidelines.html).
>>>>>> 
>>>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>>>> http://findbugs.sourceforge.net/
>>>>> 
>>>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>>>> finds is another valuable contribution.
>>>>> 
>>>>> --
>>>>> Daniel Kulp
>>>>> dkulp@apache.org
>>>>> http://dankulp.com/blog
> 
> -- 
> Daniel Kulp
> dkulp@apache.org
> http://dankulp.com/blog

Re: Apache CXF and FindBugs

Posted by Daniel Kulp <dk...@apache.org>.
On Friday 15 October 2010 4:33:17 am Ioannis Mavroukakis wrote:
> Is this due to lack of time/hardware? If so I have a hosted box that's
> mostly idle and I have some time on my hands:)

From Apache's perspective,there were a bunch of issues.   For one, they were 
trying to tie it into the Hudson instance, but the Hudson instance we have is 
already overloaded.   Second, they didn't want to run another database on the 
hudson box (again, overloaded) that Sonar needed, so they tried running it 
elsewhere, but the connection between the Hudson machines and that machine 
caused too many timeouts and such.   Then there was the issue of the Hudson 
admins not really wanting to also have to be Sonar admins and such.   
Basically, I think the approach was all wrong.   :-)

One option that I would welcome people to explore is to just contact the Sonar 
folks on their list and ask what it would take to be able to get an "admin" 
account to admin the CXF/Camel/etc... projects on their Sonar instance.   They  
might be completely open to it.  Doesn't hurt to ask.   :-)    If they say no, 
then worry about setting something up.

Dan


> 
> On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
> > was talk of setting up a Sonar instance in Apache that we could
> > completely setup and control, just never seemed to have happened.
> > 
> > I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF,
> > it would take quite a bit of work to get it to a point like where we are
> > with Checkstyle/PMD.   The starting point would need to be setting up a
> > profile to run it, then use that to find tune a config file for it that
> > sets up reasonable sets of issues, and then fix the issues.  Patches
> > welcome! :-)
> > 
> > Dan
> > 
> >> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
> >>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
> >>>> I see that CXF makes use of PMD and Checkstyle (
> >>>> http://cxf.apache.org/coding-guidelines.html).
> >>>> 
> >>>> Any reason why CXF doesn't make use of FindBugs? -
> >>>> http://findbugs.sourceforge.net/
> >>> 
> >>> Most likely, no one really pursued it.   Again, fixing issues that it
> >>> finds is another valuable contribution.
> >>> 
> >>> --
> >>> Daniel Kulp
> >>> dkulp@apache.org
> >>> http://dankulp.com/blog

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog

Re: Apache CXF and FindBugs

Posted by Benson Margulies <bi...@gmail.com>.
Sonar used to make it quite difficult to set the checkstyle and pmd
rules for yourself, independent of whether nemo gives us access to
try.  They promised to make that better.

On Fri, Oct 15, 2010 at 5:35 AM, Yiannis Mavroukakis
<im...@gameaccountnetwork.com> wrote:
> Hi Johan,
>
> If there's some definition in what is required of the profile I can
> give it a go. We use sonar at my workplace as well so I have
> some experience with it.
>
> Y.
>
> On 15 October 2010 10:02, Johan Edstrom <se...@gmail.com> wrote:
>> Ioannis, it is also due to the work in defining a profile.
>>
>> On Oct 15, 2010, at 2:33 AM, Ioannis Mavroukakis wrote:
>>
>>> Is this due to lack of time/hardware? If so I have a hosted box that's mostly idle and I have some time on my hands:)
>>>
>>> On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
>>>
>>>>
>>>> was talk of setting up a Sonar instance in Apache that we could completely
>>>> setup and control, just never seemed to have happened.
>>>>
>>>> I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF, it
>>>> would take quite a bit of work to get it to a point like where we are with
>>>> Checkstyle/PMD.   The starting point would need to be setting up a profile to
>>>> run it, then use that to find tune a config file for it that sets up
>>>> reasonable sets of issues, and then fix the issues.  Patches welcome! :-)
>>>>
>>>> Dan
>>>>
>>>>
>>>>>
>>>>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>>>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>>>>> I see that CXF makes use of PMD and Checkstyle (
>>>>>>> http://cxf.apache.org/coding-guidelines.html).
>>>>>>>
>>>>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>>>>> http://findbugs.sourceforge.net/
>>>>>>
>>>>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>>>>> finds is another valuable contribution.
>>>>>>
>>>>>> --
>>>>>> Daniel Kulp
>>>>>> dkulp@apache.org
>>>>>> http://dankulp.com/blog
>>>>
>>>> --
>>>> Daniel Kulp
>>>> dkulp@apache.org
>>>> http://dankulp.com/blog
>>
>> Johan Edstrom
>>
>> joed@opennms.org
>>
>> They that can give up essential liberty to purchase a little temporary safety, deserve neither liberty nor safety.
>>
>> Benjamin Franklin, Historical Review of Pennsylvania, 1759
>>
>>
>>
>>
>>
>>
>

Re: Apache CXF and FindBugs

Posted by Yiannis Mavroukakis <im...@gameaccountnetwork.com>.
Hi Johan,

If there's some definition in what is required of the profile I can
give it a go. We use sonar at my workplace as well so I have
some experience with it.

Y.

On 15 October 2010 10:02, Johan Edstrom <se...@gmail.com> wrote:
> Ioannis, it is also due to the work in defining a profile.
>
> On Oct 15, 2010, at 2:33 AM, Ioannis Mavroukakis wrote:
>
>> Is this due to lack of time/hardware? If so I have a hosted box that's mostly idle and I have some time on my hands:)
>>
>> On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
>>
>>>
>>> was talk of setting up a Sonar instance in Apache that we could completely
>>> setup and control, just never seemed to have happened.
>>>
>>> I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF, it
>>> would take quite a bit of work to get it to a point like where we are with
>>> Checkstyle/PMD.   The starting point would need to be setting up a profile to
>>> run it, then use that to find tune a config file for it that sets up
>>> reasonable sets of issues, and then fix the issues.  Patches welcome! :-)
>>>
>>> Dan
>>>
>>>
>>>>
>>>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>>>> I see that CXF makes use of PMD and Checkstyle (
>>>>>> http://cxf.apache.org/coding-guidelines.html).
>>>>>>
>>>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>>>> http://findbugs.sourceforge.net/
>>>>>
>>>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>>>> finds is another valuable contribution.
>>>>>
>>>>> --
>>>>> Daniel Kulp
>>>>> dkulp@apache.org
>>>>> http://dankulp.com/blog
>>>
>>> --
>>> Daniel Kulp
>>> dkulp@apache.org
>>> http://dankulp.com/blog
>
> Johan Edstrom
>
> joed@opennms.org
>
> They that can give up essential liberty to purchase a little temporary safety, deserve neither liberty nor safety.
>
> Benjamin Franklin, Historical Review of Pennsylvania, 1759
>
>
>
>
>
>

Re: Apache CXF and FindBugs

Posted by Johan Edstrom <se...@gmail.com>.
Ioannis, it is also due to the work in defining a profile.

On Oct 15, 2010, at 2:33 AM, Ioannis Mavroukakis wrote:

> Is this due to lack of time/hardware? If so I have a hosted box that's mostly idle and I have some time on my hands:)
> 
> On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:
> 
>> 
>> was talk of setting up a Sonar instance in Apache that we could completely 
>> setup and control, just never seemed to have happened.
>> 
>> I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF, it 
>> would take quite a bit of work to get it to a point like where we are with 
>> Checkstyle/PMD.   The starting point would need to be setting up a profile to 
>> run it, then use that to find tune a config file for it that sets up 
>> reasonable sets of issues, and then fix the issues.  Patches welcome! :-)
>> 
>> Dan
>> 
>> 
>>> 
>>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>>> I see that CXF makes use of PMD and Checkstyle (
>>>>> http://cxf.apache.org/coding-guidelines.html).
>>>>> 
>>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>>> http://findbugs.sourceforge.net/
>>>> 
>>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>>> finds is another valuable contribution.
>>>> 
>>>> --
>>>> Daniel Kulp
>>>> dkulp@apache.org
>>>> http://dankulp.com/blog
>> 
>> -- 
>> Daniel Kulp
>> dkulp@apache.org
>> http://dankulp.com/blog

Johan Edstrom

joed@opennms.org

They that can give up essential liberty to purchase a little temporary safety, deserve neither liberty nor safety.

Benjamin Franklin, Historical Review of Pennsylvania, 1759






Re: Apache CXF and FindBugs

Posted by Ioannis Mavroukakis <im...@gameaccount.com>.
Is this due to lack of time/hardware? If so I have a hosted box that's mostly idle and I have some time on my hands:)

On 15 Oct 2010, at 04:17, Daniel Kulp <dk...@apache.org> wrote:

> 
> was talk of setting up a Sonar instance in Apache that we could completely 
> setup and control, just never seemed to have happened.
> 
> I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF, it 
> would take quite a bit of work to get it to a point like where we are with 
> Checkstyle/PMD.   The starting point would need to be setting up a profile to 
> run it, then use that to find tune a config file for it that sets up 
> reasonable sets of issues, and then fix the issues.  Patches welcome! :-)
> 
> Dan
> 
> 
>> 
>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>> I see that CXF makes use of PMD and Checkstyle (
>>>> http://cxf.apache.org/coding-guidelines.html).
>>>> 
>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>> http://findbugs.sourceforge.net/
>>> 
>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>> finds is another valuable contribution.
>>> 
>>> --
>>> Daniel Kulp
>>> dkulp@apache.org
>>> http://dankulp.com/blog
> 
> -- 
> Daniel Kulp
> dkulp@apache.org
> http://dankulp.com/blog

Re: Apache CXF and FindBugs

Posted by Daniel Kulp <dk...@apache.org>.
On Thursday 14 October 2010 8:34:55 pm Benson Margulies wrote:
> Let's slow down a bit on this idea and discuss it on the dev list.
> FindBugs has a very, very, very broad definition of a bug. I bet there
> are cases where checkstyle and findbugs *disagree* about some source
> construct.
> 
> Things it complains of should be talked over on dev before anyone
> bothers to make patches.
> 
> Our Sonar instances already runs it, I believe, so you can see what it
> complains about already.

The problem with the Sonar setup is that we have no control over it.  The 
Sonar folks set it up and pretty much uses their defaults for everything.  As 
an example, it uses THEIR checkstyle and PMD rules.   Since we run PMD and 
Checkstyle as part of our builds base on OUR preferences, we should never see 
a failure, but we do there as their rules are different.  At one point, there 
was talk of setting up a Sonar instance in Apache that we could completely 
setup and control, just never seemed to have happened.

I'm not OPPOSED to using Findbugs, but with a codebase as large as CXF, it 
would take quite a bit of work to get it to a point like where we are with 
Checkstyle/PMD.   The starting point would need to be setting up a profile to 
run it, then use that to find tune a config file for it that sets up 
reasonable sets of issues, and then fix the issues.  Patches welcome! :-)

Dan


> 
> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
> > On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
> >> I see that CXF makes use of PMD and Checkstyle (
> >> http://cxf.apache.org/coding-guidelines.html).
> >> 
> >> Any reason why CXF doesn't make use of FindBugs? -
> >> http://findbugs.sourceforge.net/
> > 
> > Most likely, no one really pursued it.   Again, fixing issues that it
> > finds is another valuable contribution.
> > 
> > --
> > Daniel Kulp
> > dkulp@apache.org
> > http://dankulp.com/blog

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog

Re: Apache CXF and FindBugs

Posted by Benson Margulies <bi...@gmail.com>.
http://nemo.sonarsource.org/project/index/117804

On Thu, Oct 14, 2010 at 9:34 PM, Robert Liguori <ro...@gmail.com> wrote:
> If Sonar (whatever that is) already runs it, then it may be nice to add this
> to the coding-guidelines page; http://cxf.apache.org/coding-guidelines.html.
>
> ... lets the user community know the software quality level you are at. :)
>
> -- Robert
>
> --------------------------------------------------
> From: "Benson Margulies" <bi...@gmail.com>
> Sent: Thursday, October 14, 2010 8:34 PM
> To: <us...@cxf.apache.org>
> Subject: Re: Apache CXF and FindBugs
>
>> Let's slow down a bit on this idea and discuss it on the dev list.
>> FindBugs has a very, very, very broad definition of a bug. I bet there
>> are cases where checkstyle and findbugs *disagree* about some source
>> construct.
>>
>> Things it complains of should be talked over on dev before anyone
>> bothers to make patches.
>>
>> Our Sonar instances already runs it, I believe, so you can see what it
>> complains about already.
>>
>>
>> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>>>
>>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>>>
>>>> I see that CXF makes use of PMD and Checkstyle (
>>>> http://cxf.apache.org/coding-guidelines.html).
>>>>
>>>> Any reason why CXF doesn't make use of FindBugs? -
>>>> http://findbugs.sourceforge.net/
>>>
>>> Most likely, no one really pursued it.   Again, fixing issues that it
>>> finds is
>>> another valuable contribution.
>>>
>>> --
>>> Daniel Kulp
>>> dkulp@apache.org
>>> http://dankulp.com/blog
>>>
>>
>

Re: Apache CXF and FindBugs

Posted by Robert Liguori <ro...@gmail.com>.
If Sonar (whatever that is) already runs it, then it may be nice to add this 
to the coding-guidelines page; http://cxf.apache.org/coding-guidelines.html.

... lets the user community know the software quality level you are at. :)

-- Robert

--------------------------------------------------
From: "Benson Margulies" <bi...@gmail.com>
Sent: Thursday, October 14, 2010 8:34 PM
To: <us...@cxf.apache.org>
Subject: Re: Apache CXF and FindBugs

> Let's slow down a bit on this idea and discuss it on the dev list.
> FindBugs has a very, very, very broad definition of a bug. I bet there
> are cases where checkstyle and findbugs *disagree* about some source
> construct.
>
> Things it complains of should be talked over on dev before anyone
> bothers to make patches.
>
> Our Sonar instances already runs it, I believe, so you can see what it
> complains about already.
>
>
> On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
>> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>>> I see that CXF makes use of PMD and Checkstyle (
>>> http://cxf.apache.org/coding-guidelines.html).
>>>
>>> Any reason why CXF doesn't make use of FindBugs? -
>>> http://findbugs.sourceforge.net/
>>
>> Most likely, no one really pursued it.   Again, fixing issues that it 
>> finds is
>> another valuable contribution.
>>
>> --
>> Daniel Kulp
>> dkulp@apache.org
>> http://dankulp.com/blog
>>
> 

Re: Apache CXF and FindBugs

Posted by Benson Margulies <bi...@gmail.com>.
Let's slow down a bit on this idea and discuss it on the dev list.
FindBugs has a very, very, very broad definition of a bug. I bet there
are cases where checkstyle and findbugs *disagree* about some source
construct.

Things it complains of should be talked over on dev before anyone
bothers to make patches.

Our Sonar instances already runs it, I believe, so you can see what it
complains about already.


On Thu, Oct 14, 2010 at 5:27 PM, Daniel Kulp <dk...@apache.org> wrote:
> On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
>> I see that CXF makes use of PMD and Checkstyle (
>> http://cxf.apache.org/coding-guidelines.html).
>>
>> Any reason why CXF doesn't make use of FindBugs? -
>> http://findbugs.sourceforge.net/
>
> Most likely, no one really pursued it.   Again, fixing issues that it finds is
> another valuable contribution.
>
> --
> Daniel Kulp
> dkulp@apache.org
> http://dankulp.com/blog
>

Re: Apache CXF and FindBugs

Posted by Daniel Kulp <dk...@apache.org>.
On Thursday 14 October 2010 10:53:17 am Robert Liguori wrote:
> I see that CXF makes use of PMD and Checkstyle (
> http://cxf.apache.org/coding-guidelines.html).
> 
> Any reason why CXF doesn't make use of FindBugs? -
> http://findbugs.sourceforge.net/

Most likely, no one really pursued it.   Again, fixing issues that it finds is 
another valuable contribution.

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog