[GitHub] [incubator-echarts] deqingli commented on a change in pull request #11752: fix formatter tooltip can't get value in sankey diagram #11459

[GitBox <gi...@apache.org>]

deqingli commented on a change in pull request #11752: fix formatter tooltip can't get value in sankey diagram #11459
URL: https://github.com/apache/incubator-echarts/pull/11752#discussion_r352426481
 
 

 ##########
 File path: src/chart/sankey/SankeySeries.js
 ##########
 @@ -138,6 +138,17 @@ var SankeySeries = SeriesModel.extend({
         }
     },
 
+    // Override Series.getDataParams()
+    getDataParams: function (dataIndex, dataType) {
+        var params = SankeySeries.superCall(this, 'getDataParams', dataIndex, dataType);
+        if (!params.value && dataType === 'node') {
 
 Review comment:
   OK, thanks. Frankly, I forget the special value `0`. But I think it should be:
   ```js
   if (params.value == null && dataType === 'node')
   ```
   because vlaue 0 shoule not be override

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org