[GitHub] [madlib] njayaram2 commented on a change in pull request #389: DL: Convert the keras_eval function from UDF to UDA

[GitBox <gi...@apache.org>]

njayaram2 commented on a change in pull request #389: DL: Convert the keras_eval function from UDF to UDA
URL: https://github.com/apache/madlib/pull/389#discussion_r283043117
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
 ##########
 @@ -113,10 +113,14 @@ def fit(schema_madlib, source_table, model,model_arch_table,
     # Compute total images on each segment
     gp_segment_id_col,\
     seg_ids_train,\
-    total_images_per_seg = get_images_per_seg(source_table, dependent_varname)
+    images_per_seg_train = get_images_per_seg(source_table, dependent_varname)
+
+    if not all(images_per_seg_train):
+        plpy.error("No images in training dataset!  Aborting")
 
 Review comment:
   `input_tbl_valid` function that is called in `FitInputValidator` already checks for empty tables, so this is not necessary here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services