You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Vinod K V (JIRA)" <ji...@apache.org> on 2009/09/25 07:08:16 UTC
[jira] Created: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
-----------------------------------------------------------------------------------------------------
Key: MAPREDUCE-1038
URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: build
Affects Versions: 0.21.0
Reporter: Vinod K V
Fix For: 0.21.0
This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this test in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1038:
-------------------------------------
Attachment: MAPREDUCE-1038.patch
Submitting patch to address the issue.
Interestingly, Mumak's build.xml already had an {{uptodate}} task in it for the weave-aspects. The task was somewhat useless, however, as it:
* includes all the main MapReduce {{src/java}} in its changeset
* and compared the source file mtimes vs. that of the mapreduce-$\{version\}-mumak.jar file, which isn't generated by the {{compile}} target.
I changed this to ignore the MapReduce source for uptodate-ness, (so you now have to explicitly {{ant clean}} if you want aspects rewoven after you change MapReduce but not mumak), and also to use a stamp file generated with the {{touch}} target.
No new unit tests because this is a buildfile tweak. I manually tested it in the following fashion:
{code}
cd $MAPREDUCE_HOME
ant clean # cleans state
ant test -Dtestcase=TestConfiguration # compile MapReduce, run a test. Note that weaving occurs.
ant test -Dtestcase=TestConfiguration # Observe that weaving does not occur.
touch src/java/org/apache/hadoop/mapred/JobClient.java # "change" a MapReduce file
ant test -Dtestcase=TestConfiguration # Observe that weaving does not occur.
touch src/contrib/mumak/src/java/org/apache/hadoop/mapred/SimulatorClock.java # "change" Mumak src
ant test -Dtestcase=TestConfiguration # Weaving occurs.
touch src/contrib/mumak/src/java/org/apache/hadoop/mapred/EagerTaskInitializationListenerAspects.aj # change mumak aspects
ant test -Dtestcase=TestConfiguration # Weaving occurs.
ant test -Dtestcase=TestConfiguration # No weaving required.
{code}
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1038.patch, MAPREDUCE-1038.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1038:
-------------------------------------
Attachment: (was: MAPREDUCE-1038.patch)
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773602#action_12773602 ]
Hudson commented on MAPREDUCE-1038:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #133 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/133/])
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759649#action_12759649 ]
Konstantin Boudnik commented on MAPREDUCE-1038:
-----------------------------------------------
This is the way {{iajc}} compiler works: fresh recompilation on every occasion. There's the reason why clean compile makes a lot of sense: aspects might affect unupdated java classes and the other way around. You can 'fix' it by using incremental compiler for development purposes and it will be much faster. In ant script you can ride on {{<uptodate>}} task
For more information check [antTasks-iajc-uptodate|http://www.eclipse.org/aspectj/doc/next/devguide/antTasks-iajc.html#antTasks-iajc-uptodate]
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Fix For: 0.21.0
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated MAPREDUCE-1038:
---------------------------------
Description: This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases. (was: This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this test in these cases.)
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Fix For: 0.21.0
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated MAPREDUCE-1038:
-------------------------------------
Status: Patch Available (was: Open)
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1038:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1
I committed this. Thanks, Aaron!
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767627#action_12767627 ]
Aaron Kimball commented on MAPREDUCE-1038:
------------------------------------------
Sorry about the comment-spam; JIRA responded 503 Service Unavailable so I resent the upload. If anyone has delete access, please feel free to delete duplicate comments. I'll remove the extra copies of the patch.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772939#action_12772939 ]
Hudson commented on MAPREDUCE-1038:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #105 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/105/])
. Weave Mumak aspects only if related files have changed.
Contributed by Aaron Kimball
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Hong Tang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767648#action_12767648 ]
Hong Tang commented on MAPREDUCE-1038:
--------------------------------------
+1 on Chris's patch. It only pays the cost of aspect weaving only once. If the dev is only interested in work on core mapred source package, he should probably use "compile-core" instead of "compile".
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1038:
-------------------------------------
Status: Open (was: Patch Available)
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1038:
-------------------------------------
Attachment: M1038-1.patch
{noformat}
ant test -Dtestcase=TestConfiguration # Observe that weaving does not occur.
touch src/java/org/apache/hadoop/mapred/JobClient.java # "change" a MapReduce file
ant test -Dtestcase=TestConfiguration # Observe that weaving does not occur.
{noformat}
I don't think Hudson runs a clean before testing the patched build. This means that the Mumak tests would be run against the trunk version, rather than the patched version.
The aspects *should* be re-weaved if the core classes are modified.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-1038:
-------------------------------------
Status: Patch Available (was: Open)
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767695#action_12767695 ]
Hadoop QA commented on MAPREDUCE-1038:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422636/M1038-1.patch
against trunk revision 826767.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/82/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/82/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/82/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/82/console
This message is automatically generated.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767904#action_12767904 ]
Aaron Kimball commented on MAPREDUCE-1038:
------------------------------------------
That seems reasonable. +1.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball reassigned MAPREDUCE-1038:
----------------------------------------
Assignee: Aaron Kimball
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767667#action_12767667 ]
Hadoop QA commented on MAPREDUCE-1038:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422631/MAPREDUCE-1038.patch
against trunk revision 826767.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/189/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/189/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/189/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/189/console
This message is automatically generated.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-1038) Mumak's compile-aspects target
weaves aspects even though there are no changes to the Mumak's sources
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767644#action_12767644 ]
Aaron Kimball commented on MAPREDUCE-1038:
------------------------------------------
The most common case for individual developers will not involve using the failure-injection framework or mumak. I feel like shifting the burden on developers to somehow manually disable this very time-consuming process that doesn't help their workflow is the wrong solution here. If anything, I feel like the burden should be on Hudson to run the 'clean' first, by modifying test-patch.sh.
> Mumak's compile-aspects target weaves aspects even though there are no changes to the Mumak's sources
> -----------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1038
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1038
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: build
> Affects Versions: 0.21.0
> Reporter: Vinod K V
> Assignee: Aaron Kimball
> Fix For: 0.21.0
>
> Attachments: M1038-1.patch, MAPREDUCE-1038.patch
>
>
> This is particularly time consuming and is the bottle neck even for a simple ant build. In the case where no files have been updated in Mumak, there is no reason to recompile sources along with the aspects. compile-aspects should skip this step in these cases.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.