You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/20 03:18:58 UTC

[GitHub] [pulsar] labuladong commented on pull request #17449: [fix][broker]Fix using schema to create consumer fails after using AUTO_CONSUME consumer to subscribe topic

labuladong commented on PR #17449:
URL: https://github.com/apache/pulsar/pull/17449#issuecomment-1358785876

   I think the better way to resolve this bug is to record `schemaType` in `Consumer` class:
   
   https://github.com/apache/pulsar/blob/a95bb630d76c3234ef4660d722518e642341ad3b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java#L71-L81
   
   Then when we calculate the active consumer num, we can ignore the consumers without schema:
   
   https://github.com/apache/pulsar/blob/a95bb630d76c3234ef4660d722518e642341ad3b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java#L1162-L1173
   
   I can provide another PR to implement it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org