You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2023/03/01 19:22:58 UTC
[GitHub] [bookkeeper] merlimat opened a new pull request, #3829: Avoid using thread-local WriteSet when possible
merlimat opened a new pull request, #3829:
URL: https://github.com/apache/bookkeeper/pull/3829
### Motivation
For computing WriteSet we use a `Recycler` to avoid instantiating a new object each time. While that avoid allocations, it's based on thread-locals and has non-zero cost.
In most cases the usage of WriteSet that we are doing is very basic:
* Get a `WriteSet` from the recycler
* check the bookie indices
* recycle the write-set
Instead, we can just expose a method in the `DistributionSchedule` interface and avoid any recycler or object allocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] merlimat merged pull request #3829: Avoid using thread-local WriteSet when possible
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3829:
URL: https://github.com/apache/bookkeeper/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] codecov-commenter commented on pull request #3829: Avoid using thread-local WriteSet when possible
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3829:
URL: https://github.com/apache/bookkeeper/pull/3829#issuecomment-1450751021
# [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3829](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dde5a59) into [master](https://codecov.io/gh/apache/bookkeeper/commit/a96317e3537abff1d5759356ee27fc1044740f44?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a96317e) will **decrease** coverage by `47.35%`.
> The diff coverage is `42.10%`.
```diff
@@ Coverage Diff @@
## master #3829 +/- ##
=============================================
- Coverage 68.35% 21.01% -47.35%
+ Complexity 6757 2019 -4738
=============================================
Files 473 473
Lines 40963 40950 -13
Branches 5241 5240 -1
=============================================
- Hits 28002 8607 -19395
- Misses 10706 31069 +20363
+ Partials 2255 1274 -981
```
| Flag | Coverage Δ | |
|---|---|---|
| bookie | `?` | |
| client | `?` | |
| remaining | `?` | |
| replication | `?` | |
| tls | `21.01% <42.10%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/bookkeeper/client/DistributionSchedule.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0Rpc3RyaWJ1dGlvblNjaGVkdWxlLmphdmE=) | `0.00% <ø> (-9.10%)` | :arrow_down: |
| [...va/org/apache/bookkeeper/client/LedgerChecker.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L0xlZGdlckNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (-81.65%)` | :arrow_down: |
| [...rg/apache/bookkeeper/client/PendingWriteLacOp.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1BlbmRpbmdXcml0ZUxhY09wLmphdmE=) | `0.00% <0.00%> (-74.42%)` | :arrow_down: |
| [...rg/apache/bookkeeper/conf/ServerConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY29uZi9TZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `36.54% <ø> (-41.12%)` | :arrow_down: |
| [...ava/org/apache/bookkeeper/client/PendingAddOp.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1BlbmRpbmdBZGRPcC5qYXZh) | `55.94% <40.00%> (-32.90%)` | :arrow_down: |
| [...ain/java/org/apache/bookkeeper/bookie/Journal.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0pvdXJuYWwuamF2YQ==) | `66.72% <66.66%> (-15.82%)` | :arrow_down: |
| [...kkeeper/client/RoundRobinDistributionSchedule.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L1JvdW5kUm9iaW5EaXN0cmlidXRpb25TY2hlZHVsZS5qYXZh) | `33.68% <66.66%> (-52.42%)` | :arrow_down: |
| [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/bookkeeper/proto/BookieClient.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vQm9va2llQ2xpZW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/bookkeeper/client/api/BookKeeper.java](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvY2xpZW50L2FwaS9Cb29rS2VlcGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [375 more](https://codecov.io/gh/apache/bookkeeper/pull/3829?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org