You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/11/27 16:51:52 UTC

[GitHub] dgrove-oss commented on a change in pull request #372: Helm chart providers

dgrove-oss commented on a change in pull request #372: Helm chart providers
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/372#discussion_r236752121
 
 

 ##########
 File path: helm/openwhisk/values.yaml
 ##########
 @@ -197,7 +209,7 @@ invoker:
   containerFactory:
     dind: false
     useRunc: false
-    impl: "docker"
+    impl: "kubernetes"
 
 Review comment:
   Let's leave the default here as docker due to poor cold start and log extraction performance of KubernetesContainerFactory. Change default downstream instead, or wait for #370 to get merged before enabling providers?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services