You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "korlov42 (via GitHub)" <gi...@apache.org> on 2023/09/01 10:33:15 UTC
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2530: IGNITE-20016 Introduce bulk operation to catalog
korlov42 commented on code in PR #2530:
URL: https://github.com/apache/ignite-3/pull/2530#discussion_r1312863671
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java:
##########
@@ -49,6 +50,20 @@ public interface CatalogManager extends IgniteComponent, CatalogService {
*/
CompletableFuture<Void> execute(CatalogCommand command) throws IllegalArgumentException;
+ /**
+ * Executes given list of commands atomically. That is, either all commands will be applied at once
+ * or neither of them. The whole bulk will increment catalog's version by a single point.
+ *
+ * <p>Accepts only those commands provided by builders returned by this very {@link CatalogManager}.
Review Comment:
[here](https://english.stackexchange.com/questions/113382/difference-between-this-very-and-this-particular) is a good explanation of this very ( 😉 ) construction
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManager.java:
##########
@@ -49,6 +50,20 @@ public interface CatalogManager extends IgniteComponent, CatalogService {
*/
CompletableFuture<Void> execute(CatalogCommand command) throws IllegalArgumentException;
+ /**
+ * Executes given list of commands atomically. That is, either all commands will be applied at once
+ * or neither of them. The whole bulk will increment catalog's version by a single point.
+ *
+ * <p>Accepts only those commands provided by builders returned by this very {@link CatalogManager}.
Review Comment:
[here](https://english.stackexchange.com/questions/113382/difference-between-this-very-and-this-particular) is a good explanation of this very ( 😉 ) construction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org