[GitHub] rhtyd commented on a change in pull request #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?

[gi...@git.apache.org]

rhtyd commented on a change in pull request #2203: [CLOUDSTACK-10029] All private, public, and guest interfaceses are marked as untagged ca?
URL: https://github.com/apache/cloudstack/pull/2203#discussion_r139280170
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##########
 @@ -1695,8 +1695,7 @@ public ExecutionResult prepareNetworkElementCommand(final IpAssocCommand cmd) {
                 if (nic.getBrName().equalsIgnoreCase(_linkLocalBridgeName)) {
                     broadcastUriAllocatedToVM.put("LinkLocal", nicPos);
                 } else {
-                    if (nic.getBrName().equalsIgnoreCase(_publicBridgeName) || nic.getBrName().equalsIgnoreCase(_privBridgeName) ||
-                            nic.getBrName().equalsIgnoreCase(_guestBridgeName)) {
+                    if (nic.getBrName() == null) {
 
 Review comment:
   @konstantintrushin can you consider checking using `Strings.isNullOrEmpty`?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services