You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2023/09/13 06:05:33 UTC

[GitHub] [iceberg] wForget commented on a diff in pull request #8423: Spark 3.4: Only override the JobGroupInfo property if it does not exist

wForget commented on code in PR #8423:
URL: https://github.com/apache/iceberg/pull/8423#discussion_r1324012049


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/JobGroupUtils.java:
##########
@@ -39,11 +40,16 @@ public static JobGroupInfo getJobGroupInfo(SparkContext sparkContext) {
     return new JobGroupInfo(groupId, description, Boolean.parseBoolean(interruptOnCancel));
   }
 
-  public static void setJobGroupInfo(SparkContext sparkContext, JobGroupInfo info) {
-    sparkContext.setLocalProperty(JOB_GROUP_ID, info.groupId());
+  private static void setJobGroupInfo(

Review Comment:
   Thanks, I have kept the original method and made it public.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org