You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "johanl-db (via GitHub)" <gi...@apache.org> on 2023/06/12 14:43:41 UTC
[GitHub] [spark] johanl-db opened a new pull request, #41555: [SPARK-44026] Allow providing initial value for SQLMetrics
johanl-db opened a new pull request, #41555:
URL: https://github.com/apache/spark/pull/41555
### What changes were proposed in this pull request?
This change brings a small improvement to allow creating SQLMetrics with an arbitrary initial value instead of always using `-1`.
### Why are the changes needed?
This simplifies creating metrics when there's a need for a metric with a starting value other than `-1`. For example, the Delta MERGE INTO implementation [creates today different timing metrics and set them manually to 0 after creation:](https://github.com/delta-io/delta/blob/0bec32820e95e80b6accd2c88e4d532b1247497d/spark/src/main/scala/org/apache/spark/sql/delta/commands/MergeIntoCommand.scala#L173):
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Adding tests to `SQLMetricsSuite` creating metrics with initial values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #41555: [SPARK-44026] Allow providing initial value for SQLMetrics
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #41555: [SPARK-44026] Allow providing initial value for SQLMetrics
URL: https://github.com/apache/spark/pull/41555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41555: [SPARK-44026] Allow providing initial value for SQLMetrics
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41555:
URL: https://github.com/apache/spark/pull/41555#issuecomment-1607917541
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org