You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by "Ilan Kirsh (JIRA)" <ji...@apache.org> on 2007/09/17 15:09:56 UTC

[jira] Created: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
------------------------------------------------------------------------

                 Key: JDO-530
                 URL: https://issues.apache.org/jira/browse/JDO-530
             Project: JDO
          Issue Type: Test
          Components: tck2
            Reporter: Ilan Kirsh


org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:

  "department.name HAVING COUNT(this) >= :min"

but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bouschen resolved JDO-530.
----------------------------------

    Resolution: Fixed

Checked in the patch (see revision 577042).

> ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
> ------------------------------------------------------------------------
>
>                 Key: JDO-530
>                 URL: https://issues.apache.org/jira/browse/JDO-530
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-530.patch
>
>
> org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:
>   "department.name HAVING COUNT(this) >= :min"
> but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bouschen updated JDO-530:
---------------------------------

    Attachment: JDO-530.patch

Attached is a patch (JDO-530.patch) for review.

> ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
> ------------------------------------------------------------------------
>
>                 Key: JDO-530
>                 URL: https://issues.apache.org/jira/browse/JDO-530
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-530.patch
>
>
> org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:
>   "department.name HAVING COUNT(this) >= :min"
> but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

Posted by "Craig Russell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JDO-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528542 ] 

Craig Russell commented on JDO-530:
-----------------------------------

Looks good.

> ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
> ------------------------------------------------------------------------
>
>                 Key: JDO-530
>                 URL: https://issues.apache.org/jira/browse/JDO-530
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-530.patch
>
>
> org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:
>   "department.name HAVING COUNT(this) >= :min"
> but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

Posted by "Ilan Kirsh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JDO-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528537 ] 

Ilan Kirsh commented on JDO-530:
--------------------------------

Issue is solved, thanks.

> ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
> ------------------------------------------------------------------------
>
>                 Key: JDO-530
>                 URL: https://issues.apache.org/jira/browse/JDO-530
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: JDO-530.patch
>
>
> org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:
>   "department.name HAVING COUNT(this) >= :min"
> but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JDO-530) ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name

Posted by "Michael Bouschen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JDO-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Bouschen updated JDO-530:
---------------------------------

          Component/s: tck2-legacy
        Fix Version/s: JDO 2 maintenance release 1
             Assignee: Michael Bouschen
    Affects Version/s: JDO 2 final

Correct. I will take a look and provide a patch.

> ImplicitParameters.testGrouping - uses keyword 'min' as a parameter name
> ------------------------------------------------------------------------
>
>                 Key: JDO-530
>                 URL: https://issues.apache.org/jira/browse/JDO-530
>             Project: JDO
>          Issue Type: Test
>          Components: tck2, tck2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Ilan Kirsh
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>
> org.apache.jdo.tck.query.jdoql.parameters.testGrouping() contains:
>   "department.name HAVING COUNT(this) >= :min"
> but according to section 14.4 in the spec, min is a keyword, and keywords should not be used as parameter names.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.