You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2017/12/07 19:07:24 UTC
[GitHub] Antonio-Maranhao closed pull request #1030: feat: replace shadow-borders with normal borders for more minimal look
Antonio-Maranhao closed pull request #1030: feat: replace shadow-borders with normal borders for more minimal look
URL: https://github.com/apache/couchdb-fauxton/pull/1030
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/app/addons/fauxton/navigation/components/NavBar.js b/app/addons/fauxton/navigation/components/NavBar.js
index 51cd135b4..77cb3abe1 100644
--- a/app/addons/fauxton/navigation/components/NavBar.js
+++ b/app/addons/fauxton/navigation/components/NavBar.js
@@ -95,7 +95,6 @@ class NavBar extends Component {
</div>
</div>
</nav>
- <div id="primary-nav-right-shadow"/>
</div>
);
}
diff --git a/assets/less/bootstrap/navbar.less b/assets/less/bootstrap/navbar.less
index 20ab65e01..5cf656ea3 100644
--- a/assets/less/bootstrap/navbar.less
+++ b/assets/less/bootstrap/navbar.less
@@ -25,7 +25,6 @@
#gradient > .vertical(@navbarBackgroundHighlight, @navbarBackground);
border: 1px solid @navbarBorder;
.border-radius(@baseBorderRadius);
- .box-shadow(0 1px 4px rgba(0,0,0,.065));
// Prevent floats from breaking the navbar
.clearfix();
diff --git a/assets/less/fauxton.less b/assets/less/fauxton.less
index 06eb2a428..bffd722e4 100644
--- a/assets/less/fauxton.less
+++ b/assets/less/fauxton.less
@@ -185,10 +185,8 @@ table.databases {
min-height: @collapsedNavWidth;
margin-bottom: auto;
text-shadow: none;
- .box-shadow(0px 4px 0px rgba(0,0,0,0.45));
.border-radius(0);
border-bottom: 1px solid @brandDark2;
- box-shadow: 0 4px 0 0 rgba(0, 0, 0, 0.4);
a, a:hover {
color: #cecece;
text-decoration: none;
@@ -346,7 +344,7 @@ table.databases {
ensures the flexbox height is respected */
&>div {
height: 65px;
- .bottom-shadow-border();
+ .bottom-border();
position: absolute;
width: 100%;
z-index: 2; /* needed because ace's selected row has a z-index of 1 & can't be overridden */
diff --git a/assets/less/layouts.less b/assets/less/layouts.less
index 23168191e..ea871cb11 100644
--- a/assets/less/layouts.less
+++ b/assets/less/layouts.less
@@ -156,7 +156,7 @@ body #dashboard.template-with-sidebar {
}
#dashboard-content {
border-left: 1px solid @grayLight;
- .left-shadow-border();
+ .left-border();
}
}
diff --git a/assets/less/mixins.less b/assets/less/mixins.less
index 19c6d3554..f8e5068f2 100644
--- a/assets/less/mixins.less
+++ b/assets/less/mixins.less
@@ -7,16 +7,16 @@
}
.customTransition(@prop, @delay, @a, @b, @c, @d){
--webkit-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
- -moz-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
- -ms-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
- -o-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
+-webkit-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
+ -moz-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
+ -ms-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
+ -o-transition: @prop, @delay cubic-bezier(@a, @b, @c, @d);
transition: @prop, @delay cubic-bezier(@a, @b, @c, @d); /* custom */
--webkit-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
- -moz-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
- -ms-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
- -o-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
+-webkit-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
+ -moz-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
+ -ms-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
+ -o-transition-timing-function: cubic-bezier(@a, @b, @c, @d);
transition-timing-function: cubic-bezier(@a, @b, @c, @d); /* custom */
}
@@ -28,14 +28,12 @@
transition: @arguments;
}
-.bottom-shadow-border(@height: 6px) {
+.bottom-border(@height: 6px) {
border-bottom: 1px solid #999;
- .box-shadow(0px @height 0 0 rgba(0, 0, 0, 0.1));
}
-.left-shadow-border() {
+.left-border() {
border-left: 1px solid #999;
- .box-shadow(-6px 0 rgba(0, 0, 0, 0.1));
}
.noselect() {
diff --git a/assets/less/templates.less b/assets/less/templates.less
index 711711b42..b2819ac94 100644
--- a/assets/less/templates.less
+++ b/assets/less/templates.less
@@ -50,15 +50,13 @@
}
}
-.bottom-shadow-border {
+.bottom-border {
border-bottom: 1px solid #999;
- .box-shadow(0px 6px 0 0 rgba(0, 0, 0, 0.1));
}
-.bottom-left-shadow-border {
+.bottom-left-border {
border-bottom: 1px solid #999;
border-left: 1px solid #999;
- .box-shadow(-6px 6px 0 0 rgba(0, 0, 0, 0.1));
}
@@ -98,7 +96,6 @@
#sidebar-content {
width: @sidebarWidth;
background-color: @secondarySidebar;
- margin-top: 6px;
> div.inner {
display: block;
}
@@ -136,13 +133,9 @@
height: @collapsedNavWidth;
}
-.with-sidebar .right-header-wrapper {
- .box-shadow(-7px 0 rgba(0, 0, 0, 0.1));
-}
-
.header-wrapper {
- .bottom-shadow-border();
- .box-shadow(0 6px 0 0 rgba(0, 0, 0, 0.1));
+ .bottom-border();
+ .box-shadow(0 1px 0 0 rgba(0, 0, 0, 0.1));
position: absolute;
left: 0;
right: 0;
@@ -195,7 +188,7 @@
.with-sidebar & {
border-left: 1px solid @grayLight;
- .left-shadow-border();
+ .left-border();
width: auto;
padding: 15px;
bottom: 0px;
@@ -283,11 +276,9 @@
padding: 0 0 40px;
}
border-left: 1px solid #999;
- .box-shadow(-6px 0 rgba(0, 0, 0, 0.1));
}
.right-header-wrapper {
border-left: 1px solid #999;
- .box-shadow(-6px 0 rgba(0, 0, 0, 0.1));
.faux-header__searchboxwrapper {
display: none;
}
diff --git a/assets/less/trays.less b/assets/less/trays.less
index efe19b5d5..0d55e805d 100644
--- a/assets/less/trays.less
+++ b/assets/less/trays.less
@@ -23,7 +23,6 @@
}
.tray {
- .bottom-left-shadow-border;
display: none;
position: absolute;
right: 5px;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services